This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
chore(xtask): Part 8: Add line breaks before doc comments #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
refactor/comments-infrastructure
branch
from
4327f88
to
1362393
Compare
MichaReiser
force-pushed
the
refactor/js-syntax-comments
branch
2 times, most recently
from
c2038ef
to
9f33f98
Compare
leops
approved these changes
Sep 21, 2022
Base automatically changed from
refactor/js-syntax-comments
to
refactor/comments
September 22, 2022 06:13
MichaReiser
force-pushed
the
refactor/comments-infrastructure
branch
from
beb55c1
to
ba64695
Compare
MichaReiser
added a commit
that referenced
this pull request
Sep 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the comments refactoring #3227.
Summary
This PR changes the binding code gen to emit leading line breaks before doc comments.
It contains a few more changes but I hope that's ok:
cargo codegen formattergenerates files that use theFormatUnknownNodeRulefor unknown nodes.countfeature toxtask benchto easily get the counts of any type usingcountmeTest Plan
Generated the bindings and formatted them with the new formatter.