Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_semantic): correctly push/pop scopes for ts function types #3317

Merged
merged 2 commits into from
Oct 4, 2022
Merged

fix(rome_js_semantic): correctly push/pop scopes for ts function types #3317

merged 2 commits into from
Oct 4, 2022

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Oct 3, 2022

Summary

Closes #3170

Test Plan

> cargo test -p rome_js_semantic -- ok_typescript_function_type

@netlify
Copy link

netlify bot commented Oct 3, 2022 •
edited
Loading

✅ Deploy Preview for rometools canceled.

Name Link
🔨 Latest commit 44d21ac
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/633b4dc17b372d00084e1989

@xunilrj xunilrj temporarily deployed to netlify-playground October 3, 2022 20:56 Inactive
@xunilrj xunilrj added this to the 0.10.0 milestone Oct 3, 2022
@xunilrj xunilrj temporarily deployed to netlify-playground October 3, 2022 21:01 Inactive
@github-actions
Copy link

github-actions bot commented Oct 3, 2022 •
edited
Loading

Playground for commit f3d34f5

@ematipico ematipico removed this from the 0.10.0 milestone Oct 4, 2022
@ematipico ematipico added the A-Linter Area: linter label Oct 4, 2022
@ematipico ematipico merged commit 2f552e7 into main Oct 4, 2022
@ematipico ematipico deleted the fix/3170-ts-function-type-scope branch October 4, 2022 07:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-Linter Area: linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 noUnusedVariables incorrect in TS function with callback with same argument name
2 participants
@xunilrj @ematipico