Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze): useValidAnchor considering all possible expressions #3599

Merged
merged 4 commits into from
Nov 9, 2022
Merged

fix(rome_js_analyze): useValidAnchor considering all possible expressions #3599

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f29ff8a
useValidAnchor considering all possible expressions
xunilrj Nov 8, 2022
d2fbe92
fmt and clippy issues
xunilrj Nov 9, 2022
eced59e
support for computed member expression
xunilrj Nov 9, 2022
f98920e
more examples of accepted expressions
xunilrj Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 51 additions & 33 deletions crates/rome_js_analyze/src/analyzers/a11y/use_valid_anchor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,47 +268,65 @@ fn is_invalid_anchor(anchor_attribute: &JsxAttribute) -> Option<UseValidAnchorSt
match attribute_value {
JsxAnyAttributeValue::JsxExpressionAttributeValue(attribute_value) => {
let expression = attribute_value.expression().ok()?;
// href={null}
if let JsAnyExpression::JsAnyLiteralExpression(
JsAnyLiteralExpression::JsNullLiteralExpression(null),
) = expression
{
return Some(UseValidAnchorState::IncorrectHref(
null.syntax().text_trimmed_range(),
));
} else if let JsAnyExpression::JsIdentifierExpression(identifier) = expression {
let text = identifier.name().ok()?.value_token().ok()?;
// href={undefined}
if text.text_trimmed() == "undefined" {

match expression {
// href={null}
JsAnyExpression::JsAnyLiteralExpression(
JsAnyLiteralExpression::JsNullLiteralExpression(null),
) => {
return Some(UseValidAnchorState::IncorrectHref(
text.text_trimmed_range(),
null.syntax().text_trimmed_range(),
));
}
} else if let JsAnyExpression::JsAnyLiteralExpression(
JsAnyLiteralExpression::JsStringLiteralExpression(string_literal),
) = expression
{
let text = string_literal.inner_string_text().ok()?;
if text == "#" {
return Some(UseValidAnchorState::IncorrectHref(
string_literal.syntax().text_trimmed_range(),
));
JsAnyExpression::JsIdentifierExpression(identifier) => {
let text = identifier.name().ok()?.value_token().ok()?;
// href={undefined}
if text.text_trimmed() == "undefined" {
return Some(UseValidAnchorState::IncorrectHref(
text.text_trimmed_range(),
));
}
}
} else if let JsAnyExpression::JsTemplate(template) = expression {
let mut iter = template.elements().iter();
if let Some(JsAnyTemplateElement::JsTemplateChunkElement(element)) = iter.next() {
let template_token = element.template_chunk_token().ok()?;
let text = template_token.text_trimmed();
if text == "#" || text.contains("javascript:") {
JsAnyExpression::JsAnyLiteralExpression(
JsAnyLiteralExpression::JsStringLiteralExpression(string_literal),
) => {
let text = string_literal.inner_string_text().ok()?;
if text == "#" {
return Some(UseValidAnchorState::IncorrectHref(
template_token.text_trimmed_range(),
string_literal.syntax().text_trimmed_range(),
));
}
}
} else {
return Some(UseValidAnchorState::IncorrectHref(
expression.syntax().text_trimmed_range(),
));
JsAnyExpression::JsTemplate(template) => {
let mut iter = template.elements().iter();
if let Some(JsAnyTemplateElement::JsTemplateChunkElement(element)) = iter.next()
{
let template_token = element.template_chunk_token().ok()?;
let text = template_token.text_trimmed();
if text == "#" || text.contains("javascript:") {
return Some(UseValidAnchorState::IncorrectHref(
template_token.text_trimmed_range(),
));
}
}
}
JsAnyExpression::ImportMeta(_)
| JsAnyExpression::JsClassExpression(_)
| JsAnyExpression::JsImportCallExpression(_)
| JsAnyExpression::JsLogicalExpression(_)
xunilrj marked this conversation as resolved.
Show resolved Hide resolved
| JsAnyExpression::JsObjectExpression(_)
xunilrj marked this conversation as resolved.
Show resolved Hide resolved
| JsAnyExpression::JsSuperExpression(_)
| JsAnyExpression::JsUnaryExpression(_)
| JsAnyExpression::JsUnknownExpression(_)
xunilrj marked this conversation as resolved.
Show resolved Hide resolved
| JsAnyExpression::JsYieldExpression(_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would certainly be a very awkward way to write a component, but technically a yield expression may return a valid string value for href

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my view, we should either both list JsAwaitExpression and JsYieldExpression or neither of them. Because both can yield a valid URL but only if the framework supports async execution when rendering.

| JsAnyExpression::JsxTagExpression(_)
| JsAnyExpression::NewTarget(_)
| JsAnyExpression::TsNonNullAssertionExpression(_) => {
xunilrj marked this conversation as resolved.
Show resolved Hide resolved
return Some(UseValidAnchorState::IncorrectHref(
expression.syntax().text_trimmed_range(),
));
}
_ => {}
}
}
JsxAnyAttributeValue::JsxAnyTag(_) => {}
Expand Down
5 changes: 5 additions & 0 deletions crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,9 @@
<a href={`https://www.javascript.com`}/>
<a href={somewhere}/>
<a {...spread }/>
<a href={getFileUrl()}>Download</a>
<a href={a ? b : c}>Download</a>
<a href={1 + 2}>Download</a>
<a href={await getLink()}>Download</a>
<a href={a["a"]}>Download</a>
</>
5 changes: 5 additions & 0 deletions crates/rome_js_analyze/tests/specs/a11y/useValidAnchor.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ expression: useValidAnchor.jsx
<a href={`https://www.javascript.com`}/>
<a href={somewhere}/>
<a {...spread }/>
<a href={getFileUrl()}>Download</a>
<a href={a ? b : c}>Download</a>
<a href={1 + 2}>Download</a>
<a href={await getLink()}>Download</a>
<a href={a["a"]}>Download</a>
</>
```

Expand Down