Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze): Verify method name of React API calls #3619

Merged
merged 4 commits into from
Nov 9, 2022
Merged

fix(rome_js_analyze): Verify method name of React API calls #3619

merged 4 commits into from
Nov 9, 2022

Commits on Nov 9, 2022

  1. fix(rome_js_analyze): Assert React symbols resolve to react module 

    ## Summary

The `is_react_call_api` in some situations didn't test if the method name is the tested for method name.

For example, `is_react_call_api(..., "cloneElement")` returned true for `React.clone` or just `clone`.

I fixed the same issue in `jsx_member_name_is_react_fragment`

## Test Plan

I added some new tests veryfing that the logic correctly verifies the member name.
    @MichaReiser
    MichaReiser committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    556ccff View commit details
    Browse the repository at this point in the history

  2. Support React global

    @MichaReiser
    MichaReiser committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    9927363 View commit details
    Browse the repository at this point in the history

  3. Restore lib.rs

    @MichaReiser
    MichaReiser committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    806a4d9 View commit details
    Browse the repository at this point in the history

  4. Fix noArrayIndexKey test

    @MichaReiser
    MichaReiser committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    d37b991 View commit details
    Browse the repository at this point in the history