Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): implement noUnsafeFinally lint #3752

Merged
merged 8 commits into from
Nov 17, 2022
Merged

feat(rome_js_analyze): implement noUnsafeFinally lint #3752

merged 8 commits into from
Nov 17, 2022

Conversation

95th
Copy link
Contributor

@95th 95th commented Nov 15, 2022

Summary

Implement eslint's no-unsafe-finally lint

Test Plan

Unit tests added.

@95th 95th requested a review from a team November 15, 2022 18:49
@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7571dda
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637519b2924b530008533fc6
😎 Deploy Preview https://deploy-preview-3752--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MichaReiser
Copy link
Contributor

!bench_analyzer

@MichaReiser MichaReiser added the A-Linter Area: linter label Nov 16, 2022
@MichaReiser MichaReiser added this to the 11.0.0 milestone Nov 16, 2022
@github-actions
Copy link

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.01      2.5±0.03ms     4.7 MB/sec    1.00      2.4±0.03ms     4.8 MB/sec
analyzer/index.js         1.01      7.1±0.06ms     4.6 MB/sec    1.00      7.0±0.08ms     4.7 MB/sec
analyzer/lint.ts          1.01      3.5±0.01ms    11.8 MB/sec    1.00      3.5±0.03ms    11.9 MB/sec
analyzer/parser.ts        1.03      8.4±0.06ms     5.8 MB/sec    1.00      8.1±0.09ms     6.0 MB/sec
analyzer/router.ts        1.03      5.9±0.03ms    10.4 MB/sec    1.00      5.7±0.08ms    10.7 MB/sec
analyzer/statement.ts     1.03      8.2±0.03ms     4.3 MB/sec    1.00      8.0±0.09ms     4.4 MB/sec
analyzer/typescript.ts    1.02     12.6±0.15ms     4.3 MB/sec    1.00     12.4±0.17ms     4.4 MB/sec

@MichaReiser MichaReiser merged commit 16a1ac2 into rome:main Nov 17, 2022
@95th 95th deleted the no_unsafe_finally branch November 17, 2022 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants