Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): Implement noStringCaseMismatch #3794

Merged
merged 11 commits into from
Nov 22, 2022
Merged

feat(rome_js_analyze): Implement noStringCaseMismatch #3794

merged 11 commits into from
Nov 22, 2022

Conversation

95th
Copy link
Contributor

@95th 95th commented Nov 19, 2022

Summary

Closes #3368

Test Plan

cargo test -p rome_js_analyze -- no_string_case_mismatch

@95th 95th requested a review from a team November 19, 2022 08:31
@netlify
Copy link

netlify bot commented Nov 19, 2022

Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7cf217f
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/637baa8c01c5d20008096249
😎 Deploy Preview https://deploy-preview-3794--docs-rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@95th 95th changed the title feat(rome_js_analyze): Implement no_str_case_mismatch feat(rome_js_analyze): Implement no_string_case_mismatch Nov 19, 2022
@95th 95th changed the title feat(rome_js_analyze): Implement no_string_case_mismatch feat(rome_js_analyze): Implement noStringCaseMismatch Nov 19, 2022
Copy link

@JoeTorrey JoeTorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look

@JoeTorrey
Copy link

Made changes

@MichaReiser
Copy link
Contributor

!bench_analyzer

@github-actions
Copy link

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      2.5±0.02ms     4.7 MB/sec    1.02      2.5±0.02ms     4.6 MB/sec
analyzer/index.js         1.00      7.1±0.05ms     4.6 MB/sec    1.01      7.2±0.18ms     4.5 MB/sec
analyzer/lint.ts          1.03      3.6±0.03ms    11.5 MB/sec    1.00      3.5±0.03ms    11.9 MB/sec
analyzer/parser.ts        1.00      8.3±0.05ms     5.9 MB/sec    1.02      8.5±0.06ms     5.8 MB/sec
analyzer/router.ts        1.00      5.8±0.03ms    10.9 MB/sec    1.01      5.8±0.04ms    10.8 MB/sec
analyzer/statement.ts     1.00      8.1±0.06ms     4.4 MB/sec    1.01      8.2±0.07ms     4.3 MB/sec
analyzer/typescript.ts    1.00     12.2±0.11ms     4.4 MB/sec    1.02     12.5±0.13ms     4.4 MB/sec

@MichaReiser MichaReiser added A-Linter Area: linter L-JavaScript Langauge: JavaScript labels Nov 21, 2022
@MichaReiser MichaReiser added this to the 11.0.0 milestone Nov 21, 2022
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run the codegen commands again, we should be good to merge it!

@ematipico ematipico removed this from the 11.0.0 milestone Nov 21, 2022
@MichaReiser MichaReiser merged commit f0748c1 into rome:main Nov 22, 2022
@95th 95th deleted the no_string_case_mismatch branch November 23, 2022 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter L-JavaScript Langauge: JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

match_str_case_mismatch
5 participants