This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 660
feat(rome_js_analyze): Implement noStringCaseMismatch
#3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
95th
changed the title
feat(rome_js_analyze): Implement
feat(rome_js_analyze): Implement Nov 19, 2022
no_str_case_mismatch
no_string_case_mismatch
95th
changed the title
feat(rome_js_analyze): Implement
feat(rome_js_analyze): Implement Nov 19, 2022
no_string_case_mismatch
noStringCaseMismatch
JoeTorrey
approved these changes
Nov 19, 2022
JoeTorrey
reviewed
Nov 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look
Made changes |
!bench_analyzer |
Analyzer Benchmark Results
|
ematipico
reviewed
Nov 21, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_string_case_mismatch.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_string_case_mismatch.rs
Outdated
Show resolved
Hide resolved
ematipico
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you run the codegen commands again, we should be good to merge it!
leops
approved these changes
Nov 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3368
Test Plan
cargo test -p rome_js_analyze -- no_string_case_mismatch