This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 660
fix(rome_cli): Allow to run on read-only file systems #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
realtimetodie
force-pushed
the
rome-fs-read-only
branch
from
November 24, 2022 22:41
4e64425
to
699050d
Compare
realtimetodie
changed the title
fix(rome_fs): Allow to run on isolated read-only file systems
fix(rome_cli): Allow to run on isolated read-only file systems
Nov 24, 2022
leops
reviewed
Nov 25, 2022
realtimetodie
force-pushed
the
rome-fs-read-only
branch
from
November 25, 2022 21:54
6673495
to
6a252c9
Compare
The additional variant increased the complexity of the implementation. I am working on tests for this. Please do not merge yet. |
realtimetodie
force-pushed
the
rome-fs-read-only
branch
from
November 26, 2022 22:06
6a252c9
to
eaa2550
Compare
realtimetodie
force-pushed
the
rome-fs-read-only
branch
4 times, most recently
from
November 26, 2022 22:26
ec5b03e
to
410f191
Compare
realtimetodie
changed the title
fix(rome_cli): Allow to run on isolated read-only file systems
fix(rome_cli): Allow to run on read-only file systems
Nov 26, 2022
realtimetodie
force-pushed
the
rome-fs-read-only
branch
from
November 27, 2022 07:45
410f191
to
a41850c
Compare
I added integration tests for the check and format commands. |
realtimetodie
force-pushed
the
rome-fs-read-only
branch
from
November 29, 2022 01:33
a41850c
to
09d2ed8
Compare
leops
reviewed
Nov 29, 2022
realtimetodie
force-pushed
the
rome-fs-read-only
branch
from
November 30, 2022 20:36
09d2ed8
to
ac18d62
Compare
I replaced the std::fs tests with the MemoryFileSystem in read-only mode. There was another bug, where unnecessary write access to the underlying file system was required to read the rome.json configuration file. It is good that we have the tests. |
leops
approved these changes
Dec 1, 2022
MichaReiser
approved these changes
Dec 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where Rome could not process files on read-only file systems during traversal, where write access to the file system was not required.
This is required to execute Rome in isolated environments (sandboxes).
Example - Error message when running the check command on a read-only file system
$ rome check .
References