You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the clippy action that comments on the PR (falls back to a message in STDOUT for non-core members)
Updates the rust cache from version 1 to 2
Uses specific cache keys to make better use of our caches: GitHub only supports storing 10GB of caches which we easily exceed if we cache the dependencies for each job (~500mb per job)
Adds the caches to more jobs like building wasm etc.
Changes the order of Clippy and cargo check --release to first run clippy as this is the command that is more likely to fail (we only run cargo check` to detect issues specific to release builds)
Use nextest to run unit test (continues to use cargo test for doctest as doctests aren't supported by nextest yet)
Test Plan
I verified that the PR and bench workflows only rebuild the rome crates (the action only caches dependencies). We'll have to land the PR to test the changes to the main workflow.
Motorola Moto G Power, 3G connection Motorola Moto G Power • Regular 3G
16.3s from 1.07s
0.0 no change
124ms no change
1 page tested
Home
Browser previews
Chrome Desktop
iPhone, 4G LTE
Motorola Moto G Power, 3G connection
Most significant changes
Value
Budget
JS Parse & Compile Motorola Moto G Power, 3G connection
1.61s from 25ms
Total JavaScript Size in Bytes Chrome Desktop
5.36 MB from 86.8 KB
Total JavaScript Size in Bytes iPhone, 4G LTE
5.36 MB from 86.8 KB
Total JavaScript Size in Bytes Motorola Moto G Power, 3G connection
5.36 MB from 86.8 KB
JS Parse & Compile iPhone, 4G LTE
492ms from 11ms
27 other significant changes: JS Parse & Compile on Chrome Desktop, Total Blocking Time on Chrome Desktop, Largest Contentful Paint on Motorola Moto G Power, 3G connection, First Contentful Paint on Motorola Moto G Power, 3G connection, Total CSS Size in Bytes on Chrome Desktop, Total CSS Size in Bytes on iPhone, 4G LTE, Total CSS Size in Bytes on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, Time to Interactive on Motorola Moto G Power, 3G connection, Largest Contentful Paint on Chrome Desktop, First Contentful Paint on Chrome Desktop, Time to Interactive on Chrome Desktop, Number of Requests on Motorola Moto G Power, 3G connection, Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Speed Index on Motorola Moto G Power, 3G connection, Time to Interactive on iPhone, 4G LTE, First Contentful Paint on iPhone, 4G LTE, Largest Contentful Paint on iPhone, 4G LTE, Speed Index on Chrome Desktop, Total HTML Size in Bytes on Chrome Desktop, Total HTML Size in Bytes on iPhone, 4G LTE, Total HTML Size in Bytes on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Chrome Desktop
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A-ToolingArea: our own build, development, and release tooling
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo check --release to first run clippy as this is the command that is more likely to fail (we only run
cargo check` to detect issues specific to release builds)cargo test
for doctest as doctests aren't supported by nextest yet)Test Plan
I verified that the PR and bench workflows only rebuild the rome crates (the action only caches dependencies). We'll have to land the PR to test the changes to the main workflow.