Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

ci: Add more clippy & dependency checks #3896

Merged
merged 5 commits into from
Nov 29, 2022
Merged

ci: Add more clippy & dependency checks #3896

merged 5 commits into from
Nov 29, 2022

Conversation

MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented Nov 29, 2022 •
edited
Loading

Summary

  • Enables the clippy cargo checks
  • Disallows the use of dbg in non-test code
  • Adds a check for unused dependencies

Test Plan

@netlify
Copy link

netlify bot commented Nov 29, 2022 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 0ae921b
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/6385e5177ddfaa0008cae83a

@MichaReiser
ci: Add more clippy & dependency checks
721c028 
* Enables the clippy cargo checks
* Disallows the use of `dbg` in non-test code
* Adds a check for unused dependencies
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45879 45879 0
Passed 44936 44936 0
Failed 943 943 0
Panics 0 0 0
Coverage 97.94% 97.94% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 5946 5946 0
Passed 1757 1757 0
Failed 4189 4189 0
Panics 0 0 0
Coverage 29.55% 29.55% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12397 12397 0
Failed 3860 3860 0
Panics 0 0 0
Coverage 76.26% 76.26% 0.00%

@MichaReiser MichaReiser added the A-Tooling Area: our own build, development, and release tooling label Nov 29, 2022
@MichaReiser MichaReiser marked this pull request as ready for review November 29, 2022 10:25
@MichaReiser MichaReiser requested review from ematipico and a team as code owners November 29, 2022 10:25
MichaReiser
MichaReiser commented Nov 29, 2022
View reviewed changes
crates/rome_js_formatter/src/utils/binary_like_expression.rs
@@ -43,7 +43,7 @@
//! In the example, this only is the `|| happy`.
//!
//! Thus, the first group is: `[Left(some && thing && elsewhere), Right(|| happy)]`. The formatting formats the left side
//! as is (the call will recurse into the [JsAnyBinaryLikeExpression] formatting again) but formats the operator with the right side.
//! as is (the call will recurse into the [AnyJsBinaryLikeExpression] formatting again) but formats the operator with the right side.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some random doc fixes ;)

@calibre-analytics
Copy link

calibre-analytics bot commented Nov 29, 2022 •
edited
Loading

Comparing ci: Add more clippy & dependency checks Snapshot #2 to median since last deploy of rome.tools.

LCP? CLS? TBT?
Overall
Median across all pages and test profiles		 2.24s 
from 281ms		 0.0
no change		 193ms
no change
Chrome Desktop
Chrome Desktop • Cable		 2.24s 
from 281ms		 0.0
no change		 278ms 
from 4ms
iPhone, 4G LTE
iPhone 12 • 4G LTE		 1.11s 
from 246ms		 0.0
no change		 18ms
no change
Motorola Moto G Power, 3G connection
Motorola Moto G Power • Regular 3G		 16.6s 
from 1.06s		 0.0
no change		 193ms
no change

1 page tested

 Home

Browser previews

Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection
Chrome Desktop iPhone, 4G LTE Motorola Moto G Power, 3G connection

Most significant changes

Value Budget
JS Parse & Compile
Motorola Moto G Power, 3G connection		 2.02s 
from 25ms
Total Blocking Time
Chrome Desktop		 278ms 
from 4ms
Total JavaScript Size in Bytes
Chrome Desktop		 5.37 MB 
from 86.8 KB
Total JavaScript Size in Bytes
iPhone, 4G LTE		 5.37 MB 
from 86.8 KB
Total JavaScript Size in Bytes
Motorola Moto G Power, 3G connection		 5.37 MB 
from 86.8 KB

27 other significant changes: JS Parse & Compile on iPhone, 4G LTE, JS Parse & Compile on Chrome Desktop, Largest Contentful Paint on Motorola Moto G Power, 3G connection, First Contentful Paint on Motorola Moto G Power, 3G connection, Total CSS Size in Bytes on Chrome Desktop, Total CSS Size in Bytes on iPhone, 4G LTE, Total CSS Size in Bytes on Motorola Moto G Power, 3G connection, Time to Interactive on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, Time to Interactive on Chrome Desktop, Number of Requests on Motorola Moto G Power, 3G connection, Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Largest Contentful Paint on Chrome Desktop, First Contentful Paint on Chrome Desktop, Speed Index on Motorola Moto G Power, 3G connection, Time to Interactive on iPhone, 4G LTE, First Contentful Paint on iPhone, 4G LTE, Largest Contentful Paint on iPhone, 4G LTE, Speed Index on Chrome Desktop, Total HTML Size in Bytes on Chrome Desktop, Total HTML Size in Bytes on iPhone, 4G LTE, Total HTML Size in Bytes on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Chrome Desktop

Calibre: Site dashboard | View this PR | Edit settings | View documentation

leops
leops approved these changes Nov 29, 2022
View reviewed changes
crates/rome_js_syntax/src/union_ext.rs Outdated Show resolved Hide resolved
@MichaReiser MichaReiser merged commit d9d8211 into main Nov 29, 2022
@MichaReiser MichaReiser deleted the ci/more-checks branch November 29, 2022 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leops leops leops approved these changes

@ematipico ematipico Awaiting requested review from ematipico

Assignees
No one assigned
Labels
A-Tooling Area: our own build, development, and release tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaReiser @leops