This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): complete rule useAriaPropsForRole
#3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
leops
reviewed
Dec 1, 2022
MichaReiser
reviewed
Dec 1, 2022
MichaReiser
reviewed
Dec 1, 2022
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_props_for_role.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/aria_analyzers/nursery/use_aria_props_for_role.rs
Outdated
Show resolved
Hide resolved
MichaReiser
reviewed
Dec 1, 2022
ematipico
force-pushed
the
feat/use-aria-props-for-role
branch
from
aac82b9
to
2d30a43
Compare
MichaReiser
approved these changes
Dec 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3822
This PR adds all the ARIA roles to the code base, I created a macro to facilitate the code generation, but it doesn't add all the metadata for each role. The metadata added are only the required attributes for each rule, the information needed to complete this rule.
This is the map of metadata.
Test Plan
Test cases are exhaustive, meaning that they cover all the roles that require some ARIA attribute, they have been ported from the former test suite.