This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_analyze): useExhaustiveDependencies support function syntax, or React.use* hooks and more. #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default function
✅ Deploy Preview for docs-rometools canceled.
|
ematipico
reviewed
Jun 14, 2023
| // React.useXXX case | ||
| function MyComponent13() { | ||
| let a = 1; | ||
| React.useEffect(() => { |
There was a problem hiding this comment.
We should make sure that:
Reactis importedimport React from "react", I believe we already have some API for that;Reactis not created here, e.g.
const React = { useEffect() {} }
React.useEffect();Can we create some test against these cases?
There was a problem hiding this comment.
Thank you for your review!
Can we create some test against these cases?
Yes. l'll try to update some codes to pass your test cases.
There was a problem hiding this comment.
I fixed in b644eb6!
Co-authored-by: Emanuele Stoppa <[email protected]>
ematipico
approved these changes
Jun 21, 2023
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixed most of #4330
useExhaustiveDependencies rule now works correctly
Test Plan
I added some snapshot tests.
Changelog
Documentation