-
Notifications
You must be signed in to change notification settings - Fork 660
feat(rome_json_analyze): noDuplicateKeys #4592
Conversation
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
722c212
to
81116af
Compare
Parser conformance results on ubuntu-latestjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
70ccab4
to
2df6361
Compare
2b09f59
to
b58acb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we keep adding rules, I am wondering how a user knows if a rule is for a language A or a language B.
For instance, the current rule noDuplicateKeys
could easily be confused with noDuplicateObjectKeys
. Should we rename it to noDuplicateJsonKeys
?
EDIT: However, this could result in adding Json
in any JSON lint rules?
crates/rome_json_analyze/src/analyzers/nursery/no_duplicate_keys.rs
Outdated
Show resolved
Hide resolved
crates/rome_json_analyze/src/analyzers/nursery/no_duplicate_keys.rs
Outdated
Show resolved
Hide resolved
crates/rome_json_analyze/src/analyzers/nursery/no_duplicate_keys.rs
Outdated
Show resolved
Hide resolved
crates/rome_json_analyze/src/analyzers/nursery/no_duplicate_keys.rs
Outdated
Show resolved
Hide resolved
That's the good thing about that rome, a rule is language agnostic. In the previous version of rome (the TS one), some rules were able to run in JSX and HTML (mainly the I believe we are not there yet though, in terms of architecture. |
b58acb2
to
416cd37
Compare
Since we have |
Going to merge this. I'll follow up with a PR to integrate it with the workspace, and I am going to add some documentation too. Changelog as well, obviously |
Summary
Part of #4444
I created a new crate and rule under the
nursery
group. Updated all the configuration scripts too.Test Plan
Added new test cases.
Changelog
Documentation