This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_js_analyze): relax noConfusingArrow #4593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I often encounter the warnings of
noConfusingArrow
and I am starting to disable it.The rule looks too pedantic.
This PR relaxes
noConfusingArrow
by accepting all arrow functions that enclose its parameter with parenthesis.Thus, the following snippet no longer triggers the rule:
The following snippet still triggers the rule:
This means that code formatted by Rome can no longer trigger this rule.
Another solution could be to remove the rule.
Test Plan
Tests updated.
Changelog
Documentation