feat(rome_js_formatter, rome_cli): add arrowParentheses option

[SuperchupuDev]

Summary

Closes #4666

Personally, the only thing that's keeping me for migrating to Rome formatter-wise is the lack of an arrowParens formatter option. Most developers don't really want to change their code style just to migrate to a new tool, especially when this change affects code readability.

This pull requests adds an --arrow-parentheses option (similar to prettier's arrowParens) that can be set to:

• always for always adding parentheses to arrow functions
• as-needed for only adding parentheses where it's necessary

Test Plan

Made all arrow function tests also run on "arrow_parentheses": "AsNeeded"

[netlify]

✅ Deploy Preview for docs-rometools ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	aa140cb
🔍 Latest deploy log	https://app.netlify.com/sites/docs-rometools/deploys/64b5041c61e77b0008e87593
😎 Deploy Preview	https://deploy-preview-4667--docs-rometools.netlify.app/playground
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[ematipico]

For testing, here's a start. We have our arrow function testing suite. What you need to is to create an options.json file in that folder. You can copy the way we do here: https://github.com/rome/tools/blob/main/crates/rome_js_formatter/tests/specs/js/module/no-semi/options.json

Then you'd have to update the testing suite, so it can read the new option. Here is where you can do that.

Once you've done it, run the command just test-crate rome_js_formatter, or run the command cargo t from inside the rome_js_formatter/ folder.

The test suite will update ALL the snapshot tests with a new test case with the new options. There, you can check if the formatting is what you expect to be.

[SuperchupuDev]

just updated them, but i'm not sure if i did it correctly, the new tests (or rather outputs) this added look completely the same as the other ones

[ematipico]

just updated them, but i'm not sure if i did it correctly, the new tests (or rather outputs) this added look completely the same as the other ones

I'm not really sure tbh, the code looks good. I would need to debug it. It seems that the option is still not passed/overridden.

[ematipico]

That's a fantastic addition! Thank you for implementing it!

Two things before merging the PR:

• if you can revert changes that belong to the website (only the documentation, the playground is fine). We usually update the docs just before doing the release;
• if possible, add a new test case in the CLI, where we test that passing the new option yields the expected output. You can use this test as example

[ematipico]

A lot of users will be happy with this new feature! 🙌