Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_cli): show diagnostics even when --apply-unsafe is applied #4668

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

ematipico
Copy link
Contributor

Summary

Closes #4569
Closes #4633

List of changes:

  • fixed the categories of the error emitted from internalError/io to a category that reflects the command run;
  • changed the priority of the Severity of the diagnostics. Personally, I found 1 for Fatala bit unintuitive... so I changed it and how the lowest every is the lowest number, and the highest severity is the highest number. This help with ordering and filtering;
  • fixed an issue where Rome was exiting with an error code where there were only warnings;

Test Plan

Added new test cases and updated the current ones

@netlify
Copy link

netlify bot commented Jul 8, 2023

Deploy Preview for docs-rometools canceled.

Name Link
🔨 Latest commit 4a3d91a
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64a98ddf415f8a0008fe8d73

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project configuration and loading A-Diagnostic Area: errors and diagnostics labels Jul 8, 2023
@ematipico ematipico merged commit a34770f into main Jul 9, 2023
@ematipico ematipico deleted the feat/show-diagnostics-when-applied branch July 9, 2023 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-CLI Area: CLI A-Diagnostic Area: errors and diagnostics A-Project Area: project configuration and loading
Projects
None yet
1 participant