Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for exclude files #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

murilodag
Copy link

No description provided.

@murilodag
Copy link
Author

@romeovs Are you accepting updates? How long before you review and publish?

Copy link
Owner

@romeovs romeovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please use a globbing library instead of a simple prefix match.


function shouldBeIncluded(fileName, options) {
for (let i in options.excludedFiles) {
if (fileName.startsWith(options.excludedFiles[i])) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an actual glob here instead of a prefix match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants