-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow post the report to job summary #68
base: master
Are you sure you want to change the base?
Conversation
Hi @romeovs , can you please take a look at this PR? Thanks a lot! |
I've tried using the latest commit from your fork but it errors out with:
Using an older commit I took from |
Re #68 (comment), I had a simple fix to change |
* Upgrade yarn to 1.22.22, as asdf fails to install the 1.22.21 version due to 404. * Change how the github client is created according to the latest API of @actions/github. * Upgrade rollup versions, including rollup, rollup-plugin-node-externals, @rollup/plugin-commonjs, @rollup/plugin-node-resolve * Change the node package type to module, and rename the rollup.config.js to *.mjs * Change the geneartion file to dist/main.cjs * Regenerate dist/main.cjs via yarn run build
... which adds support to job summary.
ee6b8c6
to
9ca8f32
Compare
I have updated this PR and verified that it works. |
For PR from a foreign repo, the action won't have enough permission to comment on a PR, and for security reason the action shouldn't have the permission. See https://securitylab.github.com/research/github-actions-preventing-pwn-requests/, https://github.com/orgs/community/discussions/26644.
This PR implements the feature requested in #65.
I haven't tested this PR yet. I may need to upgrade the version of@actions/core
to call the newsummary
API.EDIT: I have tested this PR, and people can check the output here. The job summary also won't generate new email, so may also solve #57.