Fix bug in prod function. Add unit test

romeric · Mar 7, 2019 · 99e3ff0 · 99e3ff0
1 parent 155a50d
commit 99e3ff0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/tensor/Tensor.h b/tensor/Tensor.h
@@ -604,11 +604,11 @@ class Tensor: public AbstractTensor<Tensor<T,Rest...>,sizeof...(Rest)> {
         constexpr int stride = V::Size;
         int i = 0;
 
-        V vec =static_cast<T>(1);
+        V vec = static_cast<T>(1);
         for (; i< unroll_upto; i+=stride) {
             vec *= V(_data+i);
         }
-        T scalar = static_cast<T>(0);
+        T scalar = static_cast<T>(1);
         for (; i< Size; ++i) {
             scalar *= _data[i];
         }

diff --git a/tests/test_basics.cpp b/tests/test_basics.cpp
@@ -56,7 +56,7 @@ void test_basics() {
     assert(std::abs(norm(t8) - 46.4758001)<BigTol);
     assert(std::abs(norm(t9) - 46.4758001)<BigTol);
     assert(std::abs(norm(t10) - 7.7459667)<BigTol);
-    
+
 
     Tensor<T,2,2,2,2> t11; t11.fill(16);
     assert(std::abs(norm(static_cast<decltype(t11)>(sqrt(t11)))- 16)<BigTol);
@@ -69,6 +69,12 @@ void test_basics() {
     Tensor<T,2,2,2,2> t12 = sqrt(t11 + t11 - 2*t11 + t11/2 + 16/t11);
     assert(std::abs(norm(t12)- 12)<BigTol);
 
+    Tensor<T,10> t13;
+    t13.iota(1);
+    assert(std::abs(t13.product() - 3628800) < Tol);
+    t13.iota(0);
+    assert(std::abs(t13.product()) < Tol);
+
     print(FGRN(BOLD("All tests passed successfully")));
 
 }