Remove deprecated uses of Error::description. #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors bot
added a commit
that referenced
this pull request
Apr 2, 2020
208: Remove deprecated uses of Error::description. r=kvark a=iancormac84 Ran tests and it seems to work. Co-authored-by: iancormac84 <[email protected]>
|
Says all checks have failed. Guidance? |
|
Travis has been pretty bad lately. I think it wants us to migrate to Travis.com. |
|
(Sorry about the delay! Currently swamped with work, barely keeping with notifications) |
Closed
CAD97
reviewed
May 1, 2020
| @@ -62,7 +62,7 @@ impl fmt::Display for Error { | |||
| match *self { | |||
| Error::IoError(ref s) => write!(f, "{}", s), | |||
| Error::Message(ref s) => write!(f, "{}", s), | |||
| Error::Parser(_, pos) => write!(f, "{}: {}", pos, self.description()), | |||
| Error::Parser(_, pos) => write!(f, "{}: {}", pos, self), | |||
There was a problem hiding this comment.
This is now infinitely recursive!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran tests and it seems to work.