-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support i128 and u128 #219
Conversation
We might want to use https://docs.serde.rs/serde/macro.serde_if_integer128.html. Thoughts?
It is a good idea to be more supportive when this is cheap so I am in favor of including it. |
I just want to say that this would be a very good addition to the overall ecosystem and that it will become immediately valuable within our project; Without it, we fear that we may have to implement our own serializations 🤮 ! Really nice clean fix by the way! Looks like these changes fit very naturally in here. |
It appears these is another place that needs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thank you!
bors r+
219: Support i128 and u128 r=kvark a=e00E This PR adds support for 128 bit integers. RON does not support 128 bit integers. This is undocumented. The Readme wrongly claims that the full Serde data model is supported. Co-authored-by: Valentin Kettner <[email protected]>
@bh2smith are you able to use the git master for now? Or do you need a release soon? |
Timed out. |
This PR adds support for 128 bit integers.
RON does not support 128 bit integers. This is undocumented. The Readme wrongly claims that the full Serde data model is supported.