Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conventional module layout #222

Merged
merged 3 commits into from
May 2, 2020
Merged

Use conventional module layout #222

merged 3 commits into from
May 2, 2020

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented May 1, 2020 •
edited
Loading

This includes unifying ser::Error and de::Error.

Closes #183, closes #220, closes #221.

@CAD97
Use conventional module layout
8b3c9bd 
This includes unifying ser::Error and de::Error.
kvark
kvark approved these changes May 1, 2020
View reviewed changes
Copy link
Collaborator

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks reasonable, thank you!
bors r+

bors bot added a commit that referenced this pull request May 1, 2020
@bors @CAD97
Merge #222
2d1dc64 
222: Use conventional module layout r=kvark a=CAD97

This includes unifying ser::Error and de::Error.

Closes #220, closes #221.

Co-authored-by: CAD97 <[email protected]>
@kvark
Copy link
Collaborator

kvark commented May 1, 2020

looks like we are failing - https://travis-ci.org/github/ron-rs/ron/builds/682117741
would be nice to move to GH actions...

@kvark kvark mentioned this pull request May 1, 2020
Closed
@CAD97 CAD97 mentioned this pull request May 1, 2020
Closed
@CAD97
Copy link
Contributor Author

CAD97 commented May 1, 2020

I did test this.

I'm going to blame rust-analyzer for the fact that this doesn't pass all of the tests yet 🙃

@bors
Copy link
Contributor

bors bot commented May 1, 2020

Canceled.

@CAD97
Copy link
Contributor Author

CAD97 commented May 1, 2020

Fixed the unfixed test fallout.

@CAD97 CAD97 mentioned this pull request May 2, 2020
Merged
@kvark
Copy link
Collaborator

kvark commented May 2, 2020

Great, thank you!

@kvark kvark merged commit 168687d into ron-rs:master May 2, 2020
@CAD97 CAD97 deleted the serde-conventions branch May 2, 2020 00:30
@Veetaha
Copy link

Veetaha commented Aug 30, 2020

Hey guys, I suggest you to include this breaking change to the CHANGELOG.md, because old code that referred to ron::de::Error and ron::ser::Error types doesn't work anymore. One strange thing is that there is a path to new unified error via ron::de::Error I guess you've forgotten to remove pub use from there?

@Veetaha Veetaha mentioned this pull request Aug 31, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@CAD97 @kvark @Veetaha