Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make u128, i128 behind feature integer128 #304

Closed
wants to merge 2 commits into from

Conversation

clouds56
Copy link
Contributor

for some target that not support u128 like emscripten

@kvark
Copy link
Collaborator

kvark commented May 31, 2021

Sorry for getting late here. A feature has costs in that it needs to be tested, and as features grow the testing becomes more difficult. So generally we'd want to avoid features where possible.
Here, if some platforms don't support 128-bit integers, could we instead detect them via cfg flags?

@clouds56
Copy link
Contributor Author

clouds56 commented Jun 1, 2021

Yes, we could do this just like what it does in serde.
But I don't think it would make test easier since we have to install another compiler for test.

@kvark
Copy link
Collaborator

kvark commented Jun 1, 2021

Is this particular thing difficult to test on CI? I.e. does github CI have any platform targets that don't have 128-bit scalars?

@github-actions
Copy link

Issue has had no activity in the last 60 days and is going to be closed in 7 days if no further activity occurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants