Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #265 with better missing comma detection #353

Merged
merged 2 commits into from
Dec 25, 2021
Merged

Fix #265 with better missing comma detection #353

merged 2 commits into from
Dec 25, 2021

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Dec 25, 2021 •
edited
Loading

Fix #265 by better dealing with missing comma in CommaSeparated so that an ExpectedComma error can be reported.

  • I've included my change in CHANGELOG.md

@juntyr
Copy link
Member Author

juntyr commented Dec 25, 2021

?r @torkleyy This should be a quick fix as it really just detects the error earlier without needing any extra information

@juntyr juntyr marked this pull request as ready for review December 25, 2021 08:59
torkleyy
torkleyy approved these changes Dec 25, 2021
View reviewed changes
Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@juntyr juntyr merged commit 4e9e4fd into ron-rs:master Dec 25, 2021
@juntyr juntyr deleted the 265-comma-error branch December 25, 2021 09:25
@juntyr juntyr mentioned this pull request Dec 25, 2021
Closed
torkleyy pushed a commit to torkleyy/ron that referenced this pull request Jun 6, 2022
@juntyr @torkleyy
Fix ron-rs#265 with better missing comma detection (ron-rs#353)
7961268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkleyy torkleyy torkleyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing commas produce unhelpful errors with col/line 0
2 participants
@juntyr @torkleyy