Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for DeserializeSeed through Options #360

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Implement support for DeserializeSeed through Options #360

merged 2 commits into from
Jan 28, 2022

Conversation

juntyr
Copy link
Member

@juntyr juntyr commented Jan 26, 2022

Fixes #359

  • I've included my change in CHANGELOG.md

@juntyr
Copy link
Member Author

juntyr commented Jan 26, 2022

?r @torkleyy Thought this might be a nice quick fix for a tea break. I decided to add the DeserializeSeed variants only to the new Options API instead of further cluttering ron::de.

torkleyy
torkleyy approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Don't have much time to spend on GitHub lately, sorry.

@juntyr juntyr merged commit 23cefc9 into ron-rs:master Jan 28, 2022
@juntyr juntyr deleted the 359-deserialize-seed branch January 28, 2022 08:45
torkleyy pushed a commit to torkleyy/ron that referenced this pull request Jun 6, 2022
@juntyr @torkleyy
Implement support for DeserializeSeed through Options (ron-rs#360)
8fe116d
@torkleyy torkleyy mentioned this pull request Jun 6, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkleyy torkleyy torkleyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support DeserializeSeed
2 participants
@juntyr @torkleyy