Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant mypy overrides #412

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

felixonmars
Copy link
Contributor

pkg_resources is no longer in use, so it's not needed to override anymore.

`pkg_resources` is no longer in use, so it's not needed to override anymore.

Signed-off-by: Felix Yan <[email protected]>
@roniemartinez
Copy link
Owner

Thanks @felixonmars

Some errors need checking or the config needs some update

pyproject.toml: toml config file contains a [[tool.mypy.overrides]] section, but no module to override was specified.
tests/test_converter.py:3: error: Skipping analyzing "xmljson": module is installed, but missing library stubs or py.typed marker  [import]

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a46ca9c) 100.00% compared to head (0ab69fe) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #412   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          938       938           
=========================================
  Hits           938       938           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@felixonmars
Copy link
Contributor Author

Some errors need checking or the config needs some update

Oops. Fixed now :)

@roniemartinez
Copy link
Owner

Awesome! Thank you.

@roniemartinez roniemartinez merged commit 0aaba78 into roniemartinez:master Jul 13, 2023
@felixonmars felixonmars deleted the patch-1 branch July 13, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants