-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow xml conversion only #431
Allow xml conversion only #431
Conversation
Thanks a lot for your PR! 🙌 Could you also add tests?
Does this not require update to the |
I've added a test to check for element generation, and generation as a child of a parent element. You don't need to make any changes to the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 938 943 +5
=========================================
+ Hits 938 943 +5 ☔ View full report in Codecov by Sentry. |
Thanks @rob-blackbourn |
@all-contributors please add @rob-blackbourn for code |
I've put up a pull request to add @rob-blackbourn! 🎉 |
Great package!
I'd like write an extension for markdown using this package.
Extensions for the markdown package take an
xml...Element
. This package provides anElement
as an intermediate step, before converting it to a string with theconvert
function.This pull request splits out the element conversion stage to a function called
convert_to_element
, and changesconvert
to callconvert_to_element
. I have also added aparent
argument, to allow simple insertion of the element into an xmltree if required.
I also added a
py.typed
file, to allow the types to be visible PEP 561, and put the.vscode
folder in the.gitignore
.