Add support for multiple output files #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postmodern
reviewed
Aug 18, 2024
postmodern
requested changes
Aug 18, 2024
lib/ronin/recon/cli/commands/run.rb
Outdated
| options[:output_format].open(options[:output]) | ||
| end | ||
| output_files = outputs.filter_map do |output, output_format| | ||
| output_format.open(output) if output && output_format |
There was a problem hiding this comment.
The output && output_format test might not be necessary. Double checking OutputFormats.infer_from, it appears to default to OutputFormats::TXT, so we should always have an output format.
Ronin::Recon::OutputFormats.infer_from('foo.lol')
# => Ronin::Core::OutputFormats::TXTThere was a problem hiding this comment.
I removed only the output_format just to be 100% sure there is always an output
There was a problem hiding this comment.
There should always be path value if the --output option is given, since the argument is required.
AI-Mozi
force-pushed
the
add_support_for_multiple_output_files
branch
from
28a09b2
to
3de7e81
Compare
postmodern
force-pushed
the
0.2.0
branch
2 times, most recently
from
032be97
to
9e8f021
Compare
AI-Mozi
force-pushed
the
add_support_for_multiple_output_files
branch
from
3de7e81
to
7446b66
Compare
AI-Mozi
force-pushed
the
add_support_for_multiple_output_files
branch
from
7446b66
to
7d75441
Compare
postmodern
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#118
Loose idea, let me know what do you think @postmodern