Make cling::utils::Lookup::Named look into using directives

root-project · Sep 26, 2024 · c30873f · c30873f
1 parent dd44212
commit c30873f
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 1 deletion.
diff --git a/lib/Utils/AST.cpp b/lib/Utils/AST.cpp
@@ -1501,7 +1501,15 @@ namespace utils {
         // No definition, no lookup result.
         return;
       }
-      S->LookupQualifiedName(R, const_cast<DeclContext*>(primaryWithin));
+      bool res =
+          S->LookupQualifiedName(R, const_cast<DeclContext*>(primaryWithin));
+
+      // If the lookup fails and the context is a namespace, try to lookup in
+      // the namespaces by setting NotForRedeclaration.
+      if (!res && primaryWithin->isNamespace()) {
+        R.setRedeclarationKind(Sema::NotForRedeclaration);
+        S->LookupQualifiedName(R, const_cast<DeclContext*>(primaryWithin));
+      }
     }
   }
 

diff --git a/test/.clang-format b/test/.clang-format
@@ -0,0 +1 @@
+DisableFormat: true
diff --git a/test/Lookup/named.C b/test/Lookup/named.C
@@ -37,6 +37,13 @@ namespace AnotherNext {
 class Inside_AnotherNext {};
 }
 
+namespace A {
+  class C;
+}
+namespace B {
+  using namespace A;
+}
+
 .rawInput 0
 
 // ROOT-6095: names introduced in a scopeless enum should be available in the
@@ -106,3 +113,20 @@ decl
 decl = utils::Lookup::Named(&S, "EvenLess", context);
 decl
 //CHECK: (const clang::NamedDecl *) {{0x0*$|nullptr}}
+
+// Lookup the declaration for namespace B.
+decl = utils::Lookup::Named(&S, "B", nullptr);
+decl
+// CHECK: (const clang::NamedDecl *) 0x{{[1-9a-f][0-9a-f]*$}}
+
+const clang::DeclContext* contextB = llvm::dyn_cast<clang::DeclContext>(decl);
+contextB
+// CHECK: (const clang::DeclContext *) 0x{{[1-9a-f][0-9a-f]*$}}
+
+// Lookup 'C' from namespace B.
+decl = utils::Lookup::Named(&S, "C", contextB);
+decl
+// CHECK: (const clang::NamedDecl *) 0x{{[1-9a-f][0-9a-f]*$}}
+
+decl->getQualifiedNameAsString()
+// CHECK: (std::string) "A::C"