Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[textinput] forward search #10137

Closed
3 tasks
ferdymercury opened this issue Mar 16, 2022 · 1 comment · Fixed by #10208
Closed
3 tasks

[textinput] forward search #10137

ferdymercury opened this issue Mar 16, 2022 · 1 comment · Fixed by #10208
Assignees
@ferdymercury @jalopezg-git
Labels
in:Core Libraries new feature priority:low

Comments

@ferdymercury
Copy link
Contributor

ferdymercury commented Mar 16, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

CTRL+R works great for backward searching a command. Sometimes you click twice and you lose the command you wanted. There is no way to go backwards.

Describe the solution you'd like

Bind CTRL+S (and/or Ctrl+Shift+R) for forward search.

As done usually in Linux: https://stackoverflow.com/a/791800/7471760

Reminder:

Additional context

https://root-forum.cern.ch/t/root-command-line-editing/13648/15
#10121
@ferdymercury ferdymercury mentioned this issue Mar 16, 2022
Closed
25 tasks
ferdymercury added a commit to ferdymercury/root that referenced this issue Mar 23, 2022
@ferdymercury
[textinput] first attempt at forward history search
1b36ccc 
Fixes root-project#10137
@ferdymercury ferdymercury mentioned this issue Mar 23, 2022
Merged
2 tasks
@ferdymercury
Copy link
Contributor Author

I did a first attempt but it's not working yet: #10208

ferdymercury added a commit to ferdymercury/root that referenced this issue Mar 29, 2022
@ferdymercury
[textinput] first attempt at forward history search
fdfaaba 
Fixes root-project#10137
ferdymercury added a commit to ferdymercury/root that referenced this issue Mar 30, 2022
@ferdymercury
[textinput] implement forward history search
afcef1d 
Fixes root-project#10137

do not clear search if it was already in bkw or fwd
jalopezg-git pushed a commit to ferdymercury/root that referenced this issue Mar 31, 2022
@ferdymercury @jalopezg-git
[textinput] Implement forward history search
b3618cf 
Co-authored-by: Javier Lopez-Gomez <[email protected]>

Fixes root-project#10137
jalopezg-git pushed a commit that referenced this issue Mar 31, 2022
@ferdymercury @jalopezg-git
[textinput] Implement forward history search
e111a85 
Co-authored-by: Javier Lopez-Gomez <[email protected]>

Fixes #10137
Neel-Shah-29 pushed a commit to Neel-Shah-29/root-1 that referenced this issue Apr 6, 2022
@ferdymercury
[textinput] Implement forward history search
03ce221 
Co-authored-by: Javier Lopez-Gomez <[email protected]>

Fixes root-project#10137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferdymercury ferdymercury

@jalopezg-git jalopezg-git

Labels
in:Core Libraries new feature priority:low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[textinput] implement forward history search ferdymercury/root
2 participants
@ferdymercury @jalopezg-git