Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dict type alias fwd decl: underlying type not fwd declared #8499

Closed
Axel-Naumann opened this issue Jun 21, 2021 · 2 comments · Fixed by #8516 or #8512
Closed

Dict type alias fwd decl: underlying type not fwd declared #8499

Axel-Naumann opened this issue Jun 21, 2021 · 2 comments · Fixed by #8516 or #8512
Assignees
@Axel-Naumann
Labels
bug in:Dictionaries priority:critical
Milestone
6.24/02

Comments

@Axel-Naumann
Copy link
Member

Reported by ALICE:

G__O2DetectorsVertexing dictionary forward declarations' payload:16:53: error: no template named 'DCAFitterN'
namespace o2{namespace vertexing{using DCAFitter2 = DCAFitterN<2, o2::track::TrackParCov>;}}
                                                    ^
G__O2DetectorsVertexing dictionary forward declarations' payload:17:53: error: no template named 'DCAFitterN'
namespace o2{namespace vertexing{using DCAFitter3 = DCAFitterN<3, o2::track::TrackParCov>;}}
                                                    ^
@Axel-Naumann Axel-Naumann added this to the 6.24/02 milestone Jun 21, 2021
@Axel-Naumann Axel-Naumann self-assigned this Jun 21, 2021
@Axel-Naumann
Copy link
Member Author

Test: root-project/roottest#723

Axel-Naumann added a commit to Axel-Naumann/root that referenced this issue Jun 22, 2021
@Axel-Naumann
[cling] Also fwd decl underlying type of using decls:
7f6376c 
Before, only the using decl itself was forward declared, causing
undeclared identifiers in forward declaration code, as witnessed in
root-project#8499

Given the similarity of using and typedef, merge both into a single
function, making sure both have the same featureset, and through that
fixing this issue as a side-effect.
@Axel-Naumann Axel-Naumann mentioned this issue Jun 22, 2021
Merged
Axel-Naumann added a commit that referenced this issue Jun 23, 2021
@Axel-Naumann
[cling] Also fwd decl underlying type of using decls:
d026b49 
Before, only the using decl itself was forward declared, causing
undeclared identifiers in forward declaration code, as witnessed in
#8499

Given the similarity of using and typedef, merge both into a single
function, making sure both have the same featureset, and through that
fixing this issue as a side-effect.
Axel-Naumann added a commit to Axel-Naumann/root that referenced this issue Jun 23, 2021
@Axel-Naumann
[cling] Also fwd decl underlying type of using decls:
ae8ab21 
Before, only the using decl itself was forward declared, causing
undeclared identifiers in forward declaration code, as witnessed in
root-project#8499

Given the similarity of using and typedef, merge both into a single
function, making sure both have the same featureset, and through that
fixing this issue as a side-effect.

(cherry picked from commit d026b49)
@Axel-Naumann Axel-Naumann mentioned this issue Jun 23, 2021
Merged
This was linked to pull requests Jun 23, 2021
[cling] Also fwd decl underlying type of using decls: [v6.24] #8516
Merged
[cling] Also fwd decl underlying type of using decls: #8512
Merged
@Axel-Naumann Axel-Naumann mentioned this issue Jun 23, 2021
Merged
FonsRademakers pushed a commit to root-project/cling that referenced this issue Jun 23, 2021
@Axel-Naumann
Also fwd decl underlying type of using decls:
2d948eb 
Before, only the using decl itself was forward declared, causing
undeclared identifiers in forward declaration code, as witnessed in
root-project/root#8499

Given the similarity of using and typedef, merge both into a single
function, making sure both have the same featureset, and through that
fixing this issue as a side-effect.
Axel-Naumann added a commit that referenced this issue Jun 23, 2021
@Axel-Naumann
[cling] Also fwd decl underlying type of using decls:
9a7ea6f 
Before, only the using decl itself was forward declared, causing
undeclared identifiers in forward declaration code, as witnessed in
#8499

Given the similarity of using and typedef, merge both into a single
function, making sure both have the same featureset, and through that
fixing this issue as a side-effect.

(cherry picked from commit d026b49)
@Axel-Naumann
Copy link
Member Author

Confirmed fixed by Alice / PeterH.

pzhristov pushed a commit to alisw/root that referenced this issue Aug 27, 2021
@Axel-Naumann
[cling] Also fwd decl underlying type of using decls:
af2bd3e 
Before, only the using decl itself was forward declared, causing
undeclared identifiers in forward declaration code, as witnessed in
root-project#8499

Given the similarity of using and typedef, merge both into a single
function, making sure both have the same featureset, and through that
fixing this issue as a side-effect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Axel-Naumann Axel-Naumann

Labels
bug in:Dictionaries priority:critical
Projects
None yet
Milestone
6.24/02
1 participant
@Axel-Naumann