TClingUtils: Avoid growing paths in GetFileName #10387
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
| llvm::SmallString<256> headerFileName(headerFE->getName()); | ||
| // Remove double ../ from the path so that the search below finds a valid | ||
| // longest match and does not result in growing paths. | ||
| llvm::sys::path::remove_dots(headerFileName, /*remove_dot_dot=*/true); |
There was a problem hiding this comment.
IIUC this will break line 3402 in the original file:
size_t lenTrailing = headerFileName.size() - (IDir->data() - headerFileName.data());
There was a problem hiding this comment.
Not sure, IDir is also created referencing headerFileName. That should be fine. The use-after-free is definitely not 😐
There was a problem hiding this comment.
Let’s count on a post review here if that’s still unclear
|
Um yeah, that's a nice use-after-free right there because |
Strip of ../ so that the search finds a valid longest match. With the upcoming upgrade of LLVM 13, this would otherwise lead to an error "File name too long" but it's already wrong now.
|
Starting build on |
|
ping @vgvassilev |
| llvm::SmallString<256> headerFileName(headerFE->getName()); | ||
| // Remove double ../ from the path so that the search below finds a valid | ||
| // longest match and does not result in growing paths. | ||
| llvm::sys::path::remove_dots(headerFileName, /*remove_dot_dot=*/true); |
There was a problem hiding this comment.
Let’s count on a post review here if that’s still unclear
Strip of ../ so that the search finds a valid longest match. With the upcoming upgrade of LLVM 13, this would otherwise lead to an error "File name too long" but it's already wrong now.