gcc12's regex header file relies on a std::vector<int> instance, export it #11468
Conversation
…rt it. The C++ modules marks the std::vector<int> instantiation as not visible because it came from the `regex` header file which we did not explicitly include. root-project/root@a785402 introduces checks if certain declaration is visible in dictionary generation time which was intending to semantically improve the coherence by what the user "allowed" (or requested) rootcling to see vs what it can see globally. While this model works well it seems to not work for template instantiations as they won't be re-instantiated with visible modifier. This patch works around the current issue seen with libstdc++ 12 but a better solution would be to implement a finer grained control over the implicit template instatiations when generating a dictionary. Fixes root-project#11329
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. Errors:
Failing tests: |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Errors:
|
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Errors:
Failing tests:
And 512 more |
|
Build failed on mac11/cxx14. Errors:
|
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. Errors:
|
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Errors:
|
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Errors:
Failing tests:
And 512 more |
|
Build failed on ROOT-debian10-i386/soversion. Errors:
|
|
Build failed on mac11/cxx14. Errors:
|
|
Build failed on mac1015/cxx17. Errors:
|
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on ROOT-ubuntu2004/python3. Errors:
|
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Errors:
|
|
Build failed on ROOT-debian10-i386/soversion. Errors:
|
|
Build failed on mac11/cxx14. Errors:
|
|
Build failed on mac1015/cxx17. Errors:
|
|
@phsft-bot build just on ROOT-ubuntu18.04/nortcxxmod (as far as I can tell from inspecting the logs of the other platforms, they actually built and tested fine...) |
|
Starting build on |
|
@phsft-bot build just on ROOT-ubuntu18.04/nortcxxmod |
|
Starting build on |
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Errors:
|
The C++ modules marks the std::vector instantiation as not visible because it came from the
regexheader file which we did not explicitly include.a785402 introduces checks if certain declaration is visible in dictionary generation time which was intending to semantically improve the coherence by what the user "allowed" (or requested) rootcling to see vs what it can see globally. While this model works well it seems to not work for template instantiations as they won't be re-instantiated with visible modifier.
This patch works around the current issue seen with libstdc++ 12 but a better solution would be to implement a finer grained control over the implicit template instatiations when generating a dictionary.
Fixes #11329