CMake: use CLING_BINARY_DIR instead of LLVM_BINARY_DIR to configure ClingConfig.cmake #12153

stephanlachnit · 2023-01-29T11:36:44Z

This Pull request:

Changes or fixes:

Potential fix for #12151. Needs input from @vgvassilev for why cling_cmake_builddir was changed in 2b283cc.

I did not test this for the non-builtin case and I can't confirm this works fully since testing it is blocked by #12152.

Checklist:

tested changes locally
updated the docs (if necessary)

This PR fixes #11920.

phsft-bot · 2023-01-29T11:36:47Z

Can one of the admins verify this patch?

hahnjo · 2023-01-30T07:47:25Z

@phsft-bot build

phsft-bot · 2023-01-30T07:47:32Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

phsft-bot · 2023-01-30T09:09:51Z

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

And 383 more

vgvassilev

This PR is marked as a draft but the change looks good to me in general.

hahnjo · 2023-02-01T07:37:46Z

CLING_BINARY_DIR is set to CMAKE_CURRENT_BINARY_DIR, which in the case of ROOT is equal to CMAKE_BINARY_DIR. So can we just entirely revert 2b283cc, which would also allow us to drop a contentious patch for Clang?

ShamrockLee · 2023-02-14T07:56:51Z

When trying to build with -Dbuiltin_llvm=OFF on Nixpkgs on NixOS (x86_64-linux),

-- Configuring done
CMake Error at /nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/lib/cmake/llvm/AddLLVM.cmake:735 (add_dependencies):
  The dependency target "install-clang" of target "install-clang++" does not
  exist.

Full build log

building '/nix/store/8xsj5zq00fkbndl1zzjngmxj3hhi51hd-root-6.28.00.drv'... unpacking sources unpacking source archive /nix/store/y5m4pr7c6vgjr34zqdz7wv819ln1mkj0-source source root is source patching sources applying patch /nix/store/qljayx9yxgyx2xnf81b3rzzi99azd5d6-sw_vers.patch patching file cmake/modules/SetUpMacOS.cmake Hunk #1 succeeded at 8 with fuzz 1 (offset -20 lines). Hunk #2 succeeded at 30 (offset -20 lines). Hunk #3 succeeded at 74 (offset -34 lines). patching file config/root-config.in Hunk #1 succeeded at 313 (offset 1 line). Hunk #2 succeeded at 373 (offset 1 line). configuring patching script interpreter paths in build/unix/ build/unix/makedistsrc.sh: interpreter directive changed from "#! /bin/sh" to "/nix/store/qqa28hmysc23yy081d178jfd9a1yk8aw-bash-5.2-p15/bin/sh" build/unix/coreteam.sh: interpreter directive changed from "#!/bin/sh" to "/nix/store/qqa28hmysc23yy081d178jfd9a1yk8aw-bash-5.2-p15/bin/sh" build/unix/compiledata.sh: interpreter directive changed from "#!/usr/bin/env bash" to "/nix/store/qqa28hmysc23yy081d178jfd9a1yk8aw-bash-5.2-p15/bin/bash" build/unix/makepchinput.py: interpreter directive changed from "#! /usr/bin/env python" to "/nix/store/sp5x6s8n36gjlwck74xhj1i61p66vcpa-python3-3.10.9/bin/python" build/unix/rootmapcat.py: interpreter directive changed from "#! /usr/bin/env python" to "/nix/store/sp5x6s8n36gjlwck74xhj1i61p66vcpa-python3-3.10.9/bin/python" build/unix/makereleasenotes.sh: interpreter directive changed from "#! /bin/sh" to "/nix/store/qqa28hmysc23yy081d178jfd9a1yk8aw-bash-5.2-p15/bin/sh" build/unix/pandoc-jira.sh: interpreter directive changed from "#!/bin/bash" to "/nix/store/qqa28hmysc23yy081d178jfd9a1yk8aw-bash-5.2-p15/bin/bash" fixing cmake files... cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/share/doc/ROOT -DCMAKE_INSTALL_INFODIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/share/man -DCMAKE_INSTALL_OLDINCLUDEDIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/include -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/include -DCMAKE_INSTALL_SBINDIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_OSX_SYSROOT= -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/1y8i61anhs9hh1g5x3zw2fvdbivwixzg-gcc-wrapper-11.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/1y8i61anhs9hh1g5x3zw2fvdbivwixzg-gcc-wrapper-11.3.0/bin/ranlib -DCMAKE_AR=/nix/store/1y8i61anhs9hh1g5x3zw2fvdbivwixzg-gcc-wrapper-11.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00 -Drpath=ON -Dbuiltin_llvm=OFF -Dbuiltin_freetype=OFF -Dbuiltin_gtest=OFF -Dbuiltin_nlohmannjson=OFF -Dbuiltin_openui5=OFF -Dalien=OFF -Dbonjour=OFF -Dcastor=OFF -Dchirp=OFF -Dclad=OFF -Ddavix=ON -Ddcache=OFF -Dfail-on-missing=ON -Dfftw3=OFF -Dfitsio=OFF -Dfortran=OFF -Dgnuinstall=ON -Dimt=ON -Dgfal=OFF -Dgviz=OFF -Dhdfs=OFF -Dhttp=ON -Dkrb5=OFF -Dldap=OFF -Dmonalisa=OFF -Dmysql=OFF -Dodbc=OFF -Dopengl=ON -Doracle=OFF -Dpgsql=OFF -Dpythia6=OFF -Dpythia8=OFF -Drfio=OFF -Droot7=OFF -Dsqlite=OFF -Dssl=ON -Dtmva=ON -Dvdt=OFF -Dwebgui=OFF -Dxml=ON -Dxrootd=ON -DC_INCLUDE_DIRS=/nix/store/nasgvbblxi25r6y1s82il4m0m4ghib68-glibc-2.35-224-dev/include -- The C compiler identification is GNU 11.3.0 -- The CXX compiler identification is GNU 11.3.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /nix/store/1y8i61anhs9hh1g5x3zw2fvdbivwixzg-gcc-wrapper-11.3.0/bin/gcc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /nix/store/1y8i61anhs9hh1g5x3zw2fvdbivwixzg-gcc-wrapper-11.3.0/bin/g++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found Git: /nix/store/bslw1kzx445wxp08ykq2vdsgnr516vcq-git-2.39.1/bin/git (found version "2.39.1") -- Checking internet connectivity -- Checking internet connectivity - failed: will not automatically download external dependencies -- Looking for Python -- Found Python3: /nix/store/sp5x6s8n36gjlwck74xhj1i61p66vcpa-python3-3.10.9/bin/python3.10 (found version "3.10.9") found components: Interpreter Development NumPy Development.Module Development.Embed -- Could NOT find Python2 (missing: Python2_EXECUTABLE Python2_INCLUDE_DIRS Python2_LIBRARIES Python2_NumPy_INCLUDE_DIRS Interpreter Development NumPy Development.Module Development.Embed) Reason given by package: Interpreter: Wrong major version for the interpreter "/nix/store/sp5x6s8n36gjlwck74xhj1i61p66vcpa-python3-3.10.9/bin/python"

-- Found GCC. Major version 11, minor version 3
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Performing Test GLIBCXX_USE_CXX11_ABI
-- Performing Test GLIBCXX_USE_CXX11_ABI - Success
-- ROOT Platform: linux
-- ROOT Compiler: GNU 11.3.0
-- ROOT Processor: x86_64
-- ROOT Architecture: linuxx8664gcc
-- Build Type: 'Release' (flags = '-O3 -DNDEBUG')
-- Compiler Flags: -std=c++17 -Wno-implicit-fallthrough -Wno-noexcept-type -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -O3 -DNDEBUG
-- ROOT default compression algorithm: zlib
-- PyROOT will be built for version 3.10.9
-- Looking for ZLib
-- Found ZLIB: /nix/store/nglx459d8q4p1f1fcn1dv314hldh5h78-zlib-1.2.13/lib/libz.so (found version "1.2.13")
-- Looking for nlohmann/json.hpp
-- Found nlohmann_json: /nix/store/0ww566wjk917s42gxv3sfbiwln1wn2c9-nlohmann_json-3.11.2/share/cmake/nlohmann_json/nlohmann_jsonConfig.cmake (found suitable version "3.11.2", minimum required is "3.9")
-- Looking for Freetype
-- Found Freetype: /nix/store/mvj1y0k0n53mfdlxs8rr38vnk17ihg5n-freetype-2.12.1/lib/libfreetype.so (found version "2.12.1")
-- Looking for PCRE
-- Found PCRE: /nix/store/aq3z16pp7km0bc145mc900pjpirlap2y-pcre-8.45-dev/include (found version "8.45")
-- Looking for LZMA
-- Looking for lzma_auto_decoder in /nix/store/yf93brl22riibk7sq50sdkdflvc02pgy-xz-5.4.1/lib/liblzma.so
-- Looking for lzma_auto_decoder in /nix/store/yf93brl22riibk7sq50sdkdflvc02pgy-xz-5.4.1/lib/liblzma.so - found
-- Looking for lzma_easy_encoder in /nix/store/yf93brl22riibk7sq50sdkdflvc02pgy-xz-5.4.1/lib/liblzma.so
-- Looking for lzma_easy_encoder in /nix/store/yf93brl22riibk7sq50sdkdflvc02pgy-xz-5.4.1/lib/liblzma.so - found
-- Looking for lzma_lzma_preset in /nix/store/yf93brl22riibk7sq50sdkdflvc02pgy-xz-5.4.1/lib/liblzma.so
-- Looking for lzma_lzma_preset in /nix/store/yf93brl22riibk7sq50sdkdflvc02pgy-xz-5.4.1/lib/liblzma.so - found
-- Found LibLZMA: /nix/store/yf93brl22riibk7sq50sdkdflvc02pgy-xz-5.4.1/lib/liblzma.so (found version "5.4.1")
-- Looking for xxHash
-- Found xxHash: /nix/store/iad1hr7zcdvhi3nh3bcqq0z5i5h19can-xxHash-0.8.1/lib/libxxhash.so (found version "0.8.1")
-- Looking for ZSTD
-- Found ZSTD: /nix/store/r9p4axi2yi93c7r0q622dav3861zmr42-zstd-1.5.2/lib/libzstd.so
-- Looking for LZ4
-- Found LZ4: /nix/store/akhdv5hm8cg1p1nlzbgna2wsf31mxfvr-lz4-1.9.4/lib/liblz4.so (found version "1.9.4")
-- Looking for X11
Package expat was not found in the pkg-config search path.
Perhaps you should add the directory containing expat.pc' to the PKG_CONFIG_PATH environment variable Package 'expat', required by 'fontconfig', not found Package expat was not found in the pkg-config search path. Perhaps you should add the directory containing expat.pc'
to the PKG_CONFIG_PATH environment variable
Package 'expat', required by 'fontconfig', not found
Package expat was not found in the pkg-config search path.
Perhaps you should add the directory containing expat.pc' to the PKG_CONFIG_PATH environment variable Package 'expat', required by 'fontconfig', not found Package expat was not found in the pkg-config search path. Perhaps you should add the directory containing expat.pc'
to the PKG_CONFIG_PATH environment variable
Package 'expat', required by 'fontconfig', not found
-- Found X11: /nix/store/swvn5v81pn7x0gah3xcyw02vj3qk8zzk-xorgproto-2021.5/include
-- Looking for XOpenDisplay in /nix/store/m1msaw85h2nwkqid3m06znr1i0195j83-libX11-1.8.1/lib/libX11.so;/nix/store/473r6968sp355b1azhrq53vwn8l6ajh9-libXext-1.3.4/lib/libXext.so
-- Looking for XOpenDisplay in /nix/store/m1msaw85h2nwkqid3m06znr1i0195j83-libX11-1.8.1/lib/libX11.so;/nix/store/473r6968sp355b1azhrq53vwn8l6ajh9-libXext-1.3.4/lib/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- X11_INCLUDE_DIR: /nix/store/swvn5v81pn7x0gah3xcyw02vj3qk8zzk-xorgproto-2021.5/include;/nix/store/wc7cjzx6llh7lfwrd2jc8hg7p7qgw4iw-libX11-1.8.1-dev/include;/nix/store/njscwm3zzzkj8ainbjk7x3r46c6qj24r-libXext-1.3.4-dev/include;/nix/store/p8zz9ddnvyj34n8x3xf21hqrzs6fl541-libXft-2.3.6-dev/include;/nix/store/bkgvan3h962fx0darlpmcy1z9l7has2y-libXpm-3.5.15-dev/include;/nix/store/kyjnqlgg6gnq8dlixwpx2mpi8m8pccwm-libXrender-0.9.10-dev/include
-- X11_LIBRARIES: /nix/store/m1msaw85h2nwkqid3m06znr1i0195j83-libX11-1.8.1/lib/libX11.so;/nix/store/473r6968sp355b1azhrq53vwn8l6ajh9-libXext-1.3.4/lib/libXext.so
-- X11_Xpm_INCLUDE_PATH: /nix/store/bkgvan3h962fx0darlpmcy1z9l7has2y-libXpm-3.5.15-dev/include
-- X11_Xpm_LIB: /nix/store/36kzjj8cpkz7652c839ijrp6rslx4skh-libXpm-3.5.15/lib/libXpm.so
-- X11_Xft_INCLUDE_PATH: /nix/store/p8zz9ddnvyj34n8x3xf21hqrzs6fl541-libXft-2.3.6-dev/include
-- X11_Xft_LIB: /nix/store/b3s4j8wvzrqamajav0xfwnczgfgwkjzj-libXft-2.3.6/lib/libXft.so
-- X11_Xext_INCLUDE_PATH: /nix/store/njscwm3zzzkj8ainbjk7x3r46c6qj24r-libXext-1.3.4-dev/include
-- X11_Xext_LIB: /nix/store/473r6968sp355b1azhrq53vwn8l6ajh9-libXext-1.3.4/lib/libXext.so
-- Found GIF: /nix/store/vq0dfinvcf2zy0z1i9v9b343dv6pz0ly-giflib-5.2.1/lib/libgif.so (found version "5.2.1")
-- Found TIFF: /nix/store/4zby3xg4dayz4vfd00b9cxz9rgyr4wkr-libtiff-4.5.0/lib/libtiff.so (found version "4.5.0")
-- Found PNG: /nix/store/gzi5l4mcapicr2jmy7jz49vgxc7jyn9h-libpng-apng-1.6.39/lib/libpng.so (found version "1.6.39")
-- Found JPEG: /nix/store/2kmkz8xxsyrw1vkx2bbih73dslanc0hr-libjpeg-turbo-2.1.4/lib/libjpeg.so (found version "62")
-- Looking for AfterImage
-- Found AfterImage: /nix/store/5h69b8nd8963s6p18rx53xgscd7x2arj-libAfterImage-1.20/include/libAfterImage (found version "1.20")
-- Looking for GSL
-- Found GSL: /nix/store/qygz4zj36abjlxglak3475wbr18fjh7i-gsl-2.7.1/include (found suitable version "2.7.1", minimum required is "1.10")
-- Looking for OpenGL
-- Found OpenGL: /nix/store/8qxlk9vc11v84ir8s6c4hxi6nndqfxs3-libGL-1.5.0/lib/libOpenGL.so
-- Looking for GLEW
-- Found GLEW: /nix/store/xf7mbavhmng1s729hvkpqgj8ymkfp8dm-glew-2.2.0-dev/lib/cmake/glew/glew-config.cmake
-- Looking for gl2ps
-- Found gl2ps: /nix/store/lvm73632hn805cfwnrfqvy3zqcbn0z6k-gl2ps-1.4.2/lib/libgl2ps.so
-- Looking for LibXml2
-- Found LibXml2: /nix/store/6pcf2hzn0d4kjddj8v2rzkpr99wwnfx9-libxml2-2.10.3/lib/libxml2.so (found version "2.10.3")
-- Found OpenSSL: /nix/store/gw4hdapx2kipvjlwm8r4vg356abbi9xd-openssl-3.0.7/lib/libcrypto.so (found version "3.0.7")
-- Looking for XROOTD
-- Found untagged Xrootd version: assuming very recent (setting -DROOTXRDVERS=1000000000)
-- libXrdMain not found: xproofd will be a wrapper around xrootd
-- libXrdClient not found: use built-in
-- include_dirs: /nix/store/7g904n4vqsj77r8rmyxbrx0iza8sa4bw-xrootd-5.5.1-dev/include/xrootd;/build/source/proof/xrdinc
-- libraries: /nix/store/8ajjky60vk5dbrgciyppc8sw3dkrwb60-xrootd-5.5.1/lib/libXrdUtils.so;/nix/store/8ajjky60vk5dbrgciyppc8sw3dkrwb60-xrootd-5.5.1/lib/libXrdCl.so
-- Found FTGL: /nix/store/n8xnr87zp15xf74y52cprqy5ppk20wpp-ftgl-2.4.0/include
-- Found PkgConfig: /nix/store/v73ppkjk196bwsjm6yy9yv80bdq7q68v-pkg-config-wrapper-0.29.2/bin/pkg-config (found version "0.29.2")
-- Checking for module 'davix>=0.6.4'
-- Found davix, version 0.8.3
-- Looking for TBB
-- Found TBB: /nix/store/2d2lhp3b4fwva16v4hnxswwc99z0k3ab-tbb-2020.3 (found suitable version "2020.3", minimum required is "2018")
-- Performing Test tbb_exception_result
-- Performing Test tbb_exception_result - Success
-- Cannot select cudnn without selecting cuda or tmva-gpu. Option is ignored
-- Looking for BLAS for optional parts of TMVA
-- Looking for sgemm_
-- Looking for sgemm_ - not found
-- Looking for sgemm_
-- Looking for sgemm_ - found
-- Found BLAS: /nix/store/ar32z43050rasr218cqpg2lpk18axhrq-openblas-0.3.21/lib/libopenblas.so
-- Performing Test ROOT_HAVE_CXX_ATOMICS_WITHOUT_LIB
-- Performing Test ROOT_HAVE_CXX_ATOMICS_WITHOUT_LIB - Success
-- Found LLVM_CONFIG as /nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/bin/llvm-config
-- External llvm built in Release mode.
-- Linker detection: GNU ld
-- Building with -fPIC
-- Using LLVM external library - 13.0.1
-- Clang version: 13.0.1
-- Not building amdgpu-arch: hsa-runtime64 not found
-- Cling version (from VERSION file): ROOT_1.0~dev
-- Cling will look for C++ headers in '/nix/store/v1nxrwb4ls09sbbrwlkgxs7dlw8paksh-gcc-11.3.0/lib/gcc/x86_64-unknown-linux-gnu/11.3.0/../../../../include/c++/11.3.0:/nix/store/v1nxrwb4ls09sbbrwlkgxs7dlw8paksh-gcc-11.3.0/lib/gcc/x86_64-unknown-linux-gnu/11.3.0/../../../../include/c++/11.3.0/x86_64-unknown-linux-gnu:/nix/store/v1nxrwb4ls09sbbrwlkgxs7dlw8paksh-gcc-11.3.0/lib/gcc/x86_64-unknown-linux-gnu/11.3.0/../../../../include/c++/11.3.0/backward' at runtime.
-- And then fallback to: 'g++'
-- Performing Test CXX_HAS_fno_rtti
-- Performing Test CXX_HAS_fno_rtti - Success
-- Performing Test C_HAS_Wno_strict_overflow
-- Performing Test C_HAS_Wno_strict_overflow - Success
-- Performing Test C_HAS_Wno_maybe_uninitialized
-- Performing Test C_HAS_Wno_maybe_uninitialized - Success
-- Performing Test C_HAS_Wno_parentheses_equality
-- Performing Test C_HAS_Wno_parentheses_equality - Success
-- Looking for m
-- Looking for m - not found
-- Use SSL API VERSION 3.0 for civetweb
-- Performing Test GCC_HAS_BIDI_CHARS_FLAG
-- Performing Test GCC_HAS_BIDI_CHARS_FLAG - Failed
-- Distributed RDataFrame enabled
-- Performing Test found_setresuid
-- Performing Test found_setresuid - Success
-- Performing Test found_stdstringview
-- Performing Test found_stdstringview - Success
-- Performing Test found_stod_stringview
-- Performing Test found_stod_stringview - Failed
-- Performing Test found_opplusequal_stringview
-- Performing Test found_opplusequal_stringview - Success
-- Performing Test found_stdapply
-- Performing Test found_stdapply - Success
-- Performing Test found_stdinvoke
-- Performing Test found_stdinvoke - Success
-- Performing Test found_stdindexsequence
-- Performing Test found_stdindexsequence - Success
-- Performing Test found_attribute_always_inline
-- Performing Test found_attribute_always_inline - Success
-- Performing Test has_found_attribute_noinline
-- Performing Test has_found_attribute_noinline - Success
-- Performing Test found_hardware_interference_size
-- Performing Test found_hardware_interference_size - Failed
Running /build/source/build/unix/compiledata.sh
Making /build/source/build/ginclude/compiledata.h
-- ROOT Configuration

System Linux-5.15.86
Processor 8 core Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz (x86_64)
Build type Release
Install path /nix/store/4csvzgc3216rdp2lndklpcqr67w5mcc5-root-6.28.00
Compiler GNU 11.3.0
Compiler flags:
C -Wno-implicit-fallthrough -pipe -Wall -W -pthread -O3 -DNDEBUG
C++ -std=c++17 -Wno-implicit-fallthrough -Wno-noexcept-type -pipe -Wshadow -Wall -W -Woverloaded-virtual -fsigned-char -pthread -O3 -DNDEBUG
Linker flags:
Executable -rdynamic
Module
Shared -Wl,--no-undefined -Wl,--hash-style="both"

-- Enabled support for: asimage builtin_clang builtin_cling dataframe davix exceptions gdml gnuinstall http imt mathmore mlp minuit2 opengl pyroot roofit rpath runtime_cxxmodules shared ssl tmva tmva-cpu tmva-pymva spectrum x11 xml xrootd
-- Configuring done
CMake Error at /nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/lib/cmake/llvm/AddLLVM.cmake:735 (add_dependencies):
The dependency target "install-clang" of target "install-clang++" does not
exist.
Call Stack (most recent call first):
/nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/lib/cmake/llvm/AddLLVM.cmake:1920 (add_llvm_install_targets)
interpreter/llvm/src/tools/clang/cmake/modules/AddClang.cmake:177 (llvm_install_symlink)
interpreter/llvm/src/tools/clang/tools/driver/CMakeLists.txt:66 (add_clang_symlink)

CMake Error at /nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/lib/cmake/llvm/AddLLVM.cmake:736 (add_dependencies):
The dependency target "install-clang-stripped" of target
"install-clang++-stripped" does not exist.
Call Stack (most recent call first):
/nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/lib/cmake/llvm/AddLLVM.cmake:1920 (add_llvm_install_targets)
interpreter/llvm/src/tools/clang/cmake/modules/AddClang.cmake:177 (llvm_install_symlink)
interpreter/llvm/src/tools/clang/tools/driver/CMakeLists.txt:66 (add_clang_symlink)

CMake Error at /nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/lib/cmake/llvm/AddLLVM.cmake:735 (add_dependencies):
The dependency target "install-clang" of target "install-clang-cl" does not
exist.
Call Stack (most recent call first):
/nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/lib/cmake/llvm/AddLLVM.cmake:1920 (add_llvm_install_targets)
interpreter/llvm/src/tools/clang/cmake/modules/AddClang.cmake:177 (llvm_install_symlink)
interpreter/llvm/src/tools/clang/tools/driver/CMakeLists.txt:66 (add_clang_symlink)

CMake Error at /nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/lib/cmake/llvm/AddLLVM.cmake:736 (add_dependencies):
The dependency target "install-clang-stripped" of target
"install-clang-cl-stripped" does not exist.
Call Stack (most recent call first):
/nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/lib/cmake/llvm/AddLLVM.cmake:1920 (add_llvm_install_targets)
interpreter/llvm/src/tools/clang/cmake/modules/AddClang.cmake:177 (llvm_install_symlink)
interpreter/llvm/src/tools/clang/tools/driver/CMakeLists.txt:66 (add_clang_symlink)

-- Generating done
CMake Generate step failed. Build files cannot be regenerated correctly.
error: builder for '/nix/store/8xsj5zq00fkbndl1zzjngmxj3hhi51hd-root-6.28.00.drv' failed with exit code 1;
last 10 log lines:
> The dependency target "install-clang-stripped" of target
> "install-clang-cl-stripped" does not exist.
> Call Stack (most recent call first):
> /nix/store/ixkz33c734kgvbpmyrcjclcns88gv4vj-llvm-13.0.1-dev/lib/cmake/llvm/AddLLVM.cmake:1920 (add_llvm_install_targets)
> interpreter/llvm/src/tools/clang/cmake/modules/AddClang.cmake:177 (llvm_install_symlink)
> interpreter/llvm/src/tools/clang/tools/driver/CMakeLists.txt:66 (add_clang_symlink)
>
>
> -- Generating done
> CMake Generate step failed. Build files cannot be regenerated correctly.
For full logs, run 'nix log /nix/store/8xsj5zq00fkbndl1zzjngmxj3hhi51hd-root-6.28.00.drv'.

stephanlachnit · 2023-02-14T08:25:26Z

When trying to build with -Dbuiltin_llvm=OFF on Nixpkgs on NixOS (x86_64-linux),

This seems unrelated to this PR.

…ir." This reverts commit 2b283cc. It might not be needed, see root-project#12153 (comment)

Axel-Naumann · 2023-02-16T14:31:55Z

Thanks, @stephanlachnit !

IIUC what @hahnjo suggests then we'd close this PR in favor of a PR that reverts 2b283cc ? We can see how the revert is doing #12333 and then decide what to do with this PR.

Axel-Naumann · 2023-02-16T14:42:44Z

So can we just entirely revert 2b283cc

And the answer is: no. So we keep this PR, or do you want to look into this, @hahnjo ?

hahnjo · 2023-02-16T14:53:42Z

I'm relatively sure it can be made work if we also pass -DCLANG_DIR=${Clang_DIR} in interpreter/cling/tools/plugins/clad/CMakeLists.txt, but I won't be working on things touching interpreter/llvm/ until I can properly revert Clang patches again. So yeah, we can go ahead with this PR for now.

stephanlachnit · 2023-07-31T20:27:45Z

I'm relatively sure it can be made work if we also pass -DCLANG_DIR=${Clang_DIR} in interpreter/cling/tools/plugins/clad/CMakeLists.txt, but I won't be working on things touching interpreter/llvm/ until I can properly revert Clang patches again. So yeah, we can go ahead with this PR for now.

Any news on this? Just tested this again with your llvm16 branch and it's still required.

…lingConfig.cmake This fixes root-project#12151. Signed-off-by: Stephan Lachnit <[email protected]>

phsft-bot · 2023-07-31T21:51:08Z

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

phsft-bot · 2023-07-31T22:47:11Z

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.python.distrdf.dask.roottest_python_distrdf_dask_test_all

phsft-bot · 2023-08-01T00:06:23Z

Build failed on mac11/noimt.
Running on macphsft20.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

github-actions · 2023-08-01T01:26:59Z

Test Results

        9 files         9 suites 1d 23h 11m 31s ⏱️
  2 476 tests   2 475 ✔️ 0 💤 1 ❌
21 175 runs 21 174 ✔️ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 211f879.

♻️ This comment has been updated with latest results.

hahnjo

My approach outlined in #12153 (comment) didn't work, so I'm ok with landing this for now and tackle the Clang patch at a later point. I'll wait for @vgvassilev's final approval before merging though.

hahnjo · 2023-08-01T13:52:20Z

Any news on this? Just tested this again with your llvm16 branch and it's still required.

And sorry - yes, this fell through the cracks 😐

phsft-bot · 2023-08-02T15:50:16Z

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

projectroot.roottest.root.io.json.roottest_root_io_json_make

vgvassilev

LGTM!

stephanlachnit mentioned this pull request Jan 29, 2023

Fix libbsd linking problem with builtin_llvm=OFF #12154

Closed

2 tasks

couet assigned bellenot Jan 30, 2023

bellenot requested a review from vgvassilev January 31, 2023 09:16

vgvassilev reviewed Jan 31, 2023

View reviewed changes

stephanlachnit marked this pull request as ready for review January 31, 2023 11:25

stephanlachnit requested a review from bellenot as a code owner January 31, 2023 11:25

stephanlachnit mentioned this pull request Feb 10, 2023

[CMake] Attempt to write ClingConfig.cmake.tmp to the external LLVM library directory, causing configuration failure #11920

Closed

1 task

ShamrockLee mentioned this pull request Feb 14, 2023

root: 6.26.10 -> 6.28.06 NixOS/nixpkgs#215187

Merged

13 tasks

Axel-Naumann added a commit to Axel-Naumann/root that referenced this pull request Feb 16, 2023

Revert "Do not install {Clang,Cling}Config.cmake in the project lib d…

dc3b1a0

…ir." This reverts commit 2b283cc. It might not be needed, see root-project#12153 (comment)

Axel-Naumann mentioned this pull request Feb 16, 2023

Revert "Do not install {Clang,Cling}Config.cmake in the project lib dir" #12333

Closed

cho-m mentioned this pull request Jul 1, 2023

root 6.28.04 Homebrew/homebrew-core#114543

Merged

6 tasks

stephanlachnit mentioned this pull request Jul 31, 2023

Building fails with builtin_llvm=OFF: CommandLine Error: Option 'W' registered more than once! #12156

Closed

1 task

CMake: use CLING_BINARY_DIR instead of LLVM_BINARY_DIR to configure C…

211f879

…lingConfig.cmake This fixes root-project#12151. Signed-off-by: Stephan Lachnit <[email protected]>

stephanlachnit force-pushed the p-fix-12151 branch from 28d91b3 to 211f879 Compare July 31, 2023 21:51

hahnjo approved these changes Aug 1, 2023

View reviewed changes

vgvassilev approved these changes Aug 2, 2023

View reviewed changes

hahnjo merged commit 8a45c09 into root-project:master Aug 8, 2023
11 of 13 checks passed

stephanlachnit deleted the p-fix-12151 branch August 8, 2023 09:34

stephanlachnit mentioned this pull request Aug 8, 2023

Fix building with external LLVM #13420

Merged

2 tasks

hahnjo mentioned this pull request Aug 14, 2023

Fix building with external LLVM [v6.28] #13443

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CMake: use CLING_BINARY_DIR instead of LLVM_BINARY_DIR to configure ClingConfig.cmake #12153

CMake: use CLING_BINARY_DIR instead of LLVM_BINARY_DIR to configure ClingConfig.cmake #12153

stephanlachnit commented Jan 29, 2023 •

edited

Loading

phsft-bot commented Jan 29, 2023

hahnjo commented Jan 30, 2023

phsft-bot commented Jan 30, 2023

phsft-bot commented Jan 30, 2023

vgvassilev left a comment

hahnjo commented Feb 1, 2023

ShamrockLee commented Feb 14, 2023 •

edited

Loading

stephanlachnit commented Feb 14, 2023

Axel-Naumann commented Feb 16, 2023

Axel-Naumann commented Feb 16, 2023 •

edited

Loading

hahnjo commented Feb 16, 2023

stephanlachnit commented Jul 31, 2023

phsft-bot commented Jul 31, 2023

phsft-bot commented Jul 31, 2023

phsft-bot commented Aug 1, 2023

github-actions bot commented Aug 1, 2023 •

edited

Loading

hahnjo left a comment

hahnjo commented Aug 1, 2023

phsft-bot commented Aug 2, 2023

vgvassilev left a comment

CMake: use CLING_BINARY_DIR instead of LLVM_BINARY_DIR to configure ClingConfig.cmake #12153

CMake: use CLING_BINARY_DIR instead of LLVM_BINARY_DIR to configure ClingConfig.cmake #12153

Conversation

stephanlachnit commented Jan 29, 2023 • edited Loading

This Pull request:

Changes or fixes:

Checklist:

phsft-bot commented Jan 29, 2023

hahnjo commented Jan 30, 2023

phsft-bot commented Jan 30, 2023

phsft-bot commented Jan 30, 2023

Failing tests:

vgvassilev left a comment

Choose a reason for hiding this comment

hahnjo commented Feb 1, 2023

ShamrockLee commented Feb 14, 2023 • edited Loading

stephanlachnit commented Feb 14, 2023

Axel-Naumann commented Feb 16, 2023

Axel-Naumann commented Feb 16, 2023 • edited Loading

hahnjo commented Feb 16, 2023

stephanlachnit commented Jul 31, 2023

phsft-bot commented Jul 31, 2023

phsft-bot commented Jul 31, 2023

Failing tests:

phsft-bot commented Aug 1, 2023

Failing tests:

github-actions bot commented Aug 1, 2023 • edited Loading

Test Results

hahnjo left a comment

Choose a reason for hiding this comment

hahnjo commented Aug 1, 2023

phsft-bot commented Aug 2, 2023

Failing tests:

vgvassilev left a comment

Choose a reason for hiding this comment

stephanlachnit commented Jan 29, 2023 •

edited

Loading

ShamrockLee commented Feb 14, 2023 •

edited

Loading

Axel-Naumann commented Feb 16, 2023 •

edited

Loading

github-actions bot commented Aug 1, 2023 •

edited

Loading