Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment and network guide to reflect current status of pasta's AppArmor issue on Ubuntu #463

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Update comment and network guide to reflect current status of pasta's AppArmor issue on Ubuntu #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae0c97d
pasta: Update comment about issue with AppArmor and creation of user …
sbrivio-rh Aug 16, 2024
baec6fd
docs/network: Don't suggest removing AppArmor rules for pasta
sbrivio-rh Aug 19, 2024
3bb2efa
docs/network: Mention that pasta won't work with some Ubuntu package …
sbrivio-rh Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions docs/network.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,17 @@ If `--disable-host-loopback` is not specified, ports listening on 127.0.0.1 in t
> `--net=pasta` needs [pasta (passt)](https://passt.top/passt/) `2023_06_25.32660ce` or later.
> Using `2023_12_04.b86afe3` or later is highly recommended.
>
> Depending on the version of pasta and the host operating system,
> running `sudo apparmor_parser -R /etc/apparmor.d/usr.bin.passt` might be needed too.
> Currently, this doesn't work with some Ubuntu versions of the passt
> package:
> - `passt-0.0~git20230627.289301b-1` (Ubuntu 23.10)
> - `passt-0.0~git20240220.1e6f92b-1` (Ubuntu 24.04)
> due to a missing `usr.bin.pasta` AppArmor profile, see:
> https://bugs.launchpad.net/ubuntu/+source/passt/+bug/2077158
>
> Workaround: set the `kernel.apparmor_restrict_unprivileged_userns`
> sysctl to `0`, or (preferred) add the AppArmor profile from
> upstream, or from Debian packages, or from Ubuntu > 24.10.


Pros:
* Possible to perform network-namespaced operations, e.g. creating iptables rules, running `tcpdump`
Expand Down
11 changes: 8 additions & 3 deletions pkg/network/pasta/pasta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,14 @@ func (d *parentDriver) ConfigureNetwork(childPID int, stateDir, detachedNetNSPat
"--netns="+detachedNetNSPath)
}

// FIXME: Doesn't work with passt_0.0~git20230216.4663ccc-1_amd64.deb (Ubuntu 23.04)
// `Couldn't open user namespace /proc/51813/ns/user: Permission denied`
// Possibly related to AppArmor.
// FIXME: Doesn't work with:
// - passt-0.0~git20230627.289301b-1 (Ubuntu 23.10)
// - passt-0.0~git20240220.1e6f92b-1 (Ubuntu 24.04)
// see https://bugs.launchpad.net/ubuntu/+source/passt/+bug/2077158
//
// Workaround: set the kernel.apparmor_restrict_unprivileged_userns
// sysctl to 0, or (preferred) add the AppArmor profile from upstream,
// or from Debian packages, or from Ubuntu > 24.10.
cmd := exec.Command(d.binary, opts...)
logrus.Debugf("Executing %v", cmd.Args)
out, err := cmd.CombinedOutput()
Expand Down