Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up docblocks & commenting #459

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Clean up docblocks & commenting #459

merged 1 commit into from
Feb 18, 2020

Conversation

Log1x
Copy link
Member

@Log1x Log1x commented Aug 7, 2019

  • Opinionated change: Clean up existing docblocks as well as make them more uniform across the entire package.

@swalkinshaw
Copy link
Member

I'm iffy on the vertical aligning as I generally don't like that since they're annoying to modify. However we rarely change this stuff

@Log1x
Copy link
Member Author

Log1x commented Aug 7, 2019

I feel like Bedrock being the foundation and staple that it is, the code base should be "beautified" and as readable as possible from the end-user– especially as most of it is "dev-facing" (e.g. application.php).

I do understand the annoyance to modify the vertically aligned docblocks though– but it is indeed a fact that it is rarely to be changed.

@retlehs retlehs merged commit f9a77a0 into master Feb 18, 2020
@retlehs retlehs deleted the log1x-docblock branch February 18, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants