[bug] Bud returns "0" exit code when the build errors

[retlehs]

Describe the issue

The Bud process does not return the proper exit code when an error occurs

Expected Behavior

The process should return an exit status that isn't 0

This is critical for app deploys to fail as expected when a build doesn't complete. If a build fails but the deploy still continues, then the app can be deployed and immediately break

(Props to @joshuafredrickson for raising this on the #bud channel in the Roots Discord server)

Actual Behavior

The process returns with an exit status of 0

Steps To Reproduce

1. yarn add @roots/bud-eslint @roots/eslint-config --dev
2. Drop a .eslintrc.cjs in the project
3. Modify app.js to produce an error

Example .eslintrc.cjs:

module.exports = {
  root: true,
  extends: ['eslint:recommended'],
  rules: {},
}

Example app.js:

var test = 'test';

Example simple test.sh script to return the code:

yarn build
echo $?

version

At least 6.3.5 and 6.4.1 are affected

[kellymears]

This should be fixed in v6.4.2 by d9b606e

[LucasDemea]

I still get a 0 error code when the build should fail with bud 6.6.9:

EDIT: Updating to 6.7.0 fixed it for me