-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include theme.json
; patterns/
in translation scan command
#3076
Conversation
With recent |
@retlehs: Latest stable WP CLI appears to work fine with the used commands now, so this can be merged. To make this more robust, |
@kellymears: A dedicated command for |
theme.json
in translation scan commandtheme.json
; patterns/
in translation scan command
@retlehs, @kellymears: Current stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies for the delay, thank you for this update!
It turns out that when using
--include
withwp i18n
thetheme.json
file and thepatterns
directoryneed to be explicitly included, too, as those would be skipped otherwise.
Edit:
The latest
wp i18n
version (>=2.4.0
) is needed for some bugfixes of otherwise blocking bugs.Until
wp
CLI is also newly released with the newwp i18n
version bundled,the latest
wp i18n
version can be installed independently from thewp
CLI version by usingwp package install wp-cli/i18n-command:dev-main
and then just using it as usual (
wp i18n
).Edit (October 2023): Current stable
wp cli
2.8.1
contains a recent enoughwp i18n
.