Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 Fix the comment list output #3184

Merged
merged 1 commit into from
Feb 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/View/Composers/Comments.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function with()
{
return [
'title' => $this->title(),
'comments' => $this->comments(),
'responses' => $this->responses(),
'previous' => $this->previous(),
'next' => $this->next(),
'paginated' => $this->paginated(),
Expand All @@ -43,7 +43,7 @@ public function title()
/* translators: %1$s is replaced with the number of comments and %2$s with the post title */
_nx('%1$s response to “%2$s”', '%1$s responses to “%2$s”', get_comments_number(), 'comments title', 'sage'),
get_comments_number() === 1 ? _x('One', 'comments title', 'sage') : number_format_i18n(get_comments_number()),
'<span>'.get_the_title().'</span>'
get_the_title()
);
}

Expand All @@ -52,7 +52,7 @@ public function title()
*
* @return string
*/
public function comments()
public function responses()
{
if (! have_comments()) {
return;
Expand All @@ -61,6 +61,7 @@ public function comments()
return wp_list_comments([
'style' => 'ol',
'short_ping' => true,
'echo' => false,
]);
}

Expand Down
4 changes: 2 additions & 2 deletions resources/views/partials/comments.blade.php
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
@if (! post_password_required())
<section id="comments" class="comments">
@if ($comments)
@if ($responses)
<h2>
{!! $title !!}
</h2>

<ol class="comment-list">
@php($comments)
{!! $responses !!}
</ol>

@if ($paginated)
Expand Down
Loading