Fix subjectAltName for self-signed certificates

[swalkinshaw]

Ref: #1117

In some cases the subjectAltName for self-signed SSL certificates were
invalid due to DNS: being both prepended and appended to each domain
when it should only be a prefix.

This tweaks regex_replace to anchor at the start of the string only.

Before:

subjectAltName = DNS:example.testDNS:,DNS:www.example.testDNS:

After:

subjectAltName = DNS:example.test,DNS:www.example.test

[swalkinshaw]

@robrecord want to try this out?

[tangrufus]

How do you reproduce the extraneous DNS:?

This is my setup: tangrufus@07e3caf

➜ ansible --version
ansible 2.7.14
  config file = /Users/rufus/Desktop/trellis/ansible.cfg
  configured module search path = [u'/Users/rufus/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.17 (default, Oct 24 2019, 12:57:38) [GCC 4.2.1 Compatible Apple LLVM 11.0.0 (clang-1100.0.33.8)]

➜ ansible --version
ansible 2.8.7
  config file = /Users/rufus/Desktop/trellis/ansible.cfg
  configured module search path = [u'/Users/rufus/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.17 (default, Oct 24 2019, 12:57:38) [GCC 4.2.1 Compatible Apple LLVM 11.0.0 (clang-1100.0.33.8)]

[tangrufus]

Please ignore me.

I can reproduce the issue using python 3 and this pull request fixes it.

[swalkinshaw]

Ah glad to know it was the Python version that mattered and thanks for testing 🎉

As long as this still works as it should in Python 2 as well...

[tangrufus]

This patch also works on python 2 + anisble v2.7 & v2.8 👏

[robrecord]

I am just now upgrading an old trellis install with the DNS: problem, and after doing all the things, I can confirm your fix works for me. Python 3.7.6, Ansible v2.8.8

Things I did — not sure if all necessary:

• upgrade trellis
• remove old ssl certs inside vagrant (vagrant ssh & sudo rm -r /etc/nginx/ssl)
• removed old cert from the keychain app
• re-provisioned vagrant (SKIP_GALAXY=true ANSIBLE_TAGS=wordpress vagrant reload --provision)
• re-trust the certificate (vagrant trellis-cert trust)
• restarted browser

Thanks @swalkinshaw & @tangrufus , somehow I didn't see this PR at the time.
It was driving me crazy; I'm so pleased there is a fix!