-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CircleCI: ansible-lint
playbooks
#1134
Conversation
|
ansible-lint
playbooksansible-lint
playbooks
Ignore rule 303 ( Ignore rule 204 ( Tolerate (won't fix) these 3 warnings because our use of "dynamic import": $ ansible-lint deploy.yml dev.yml server.yml rollback.yml xdebug-tunnel.yml
WARNING: Couldn't open /home/circleci/project/roles/wordpress-install/tasks/tasks/composer-authentications.yml - No such file or directory
WARNING: Couldn't open /home/circleci/project/roles/wordpress-setup/tasks/roles/common/tasks/disable_challenge_sites.yml - No such file or directory
WARNING: Couldn't open /home/circleci/project/roles/letsencrypt/tasks/roles/common/tasks/reload_nginx.yml - No such file or directory Fixed 1 lint warning (rule 301 - Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. Looks good 🎉
ansible-lint
is useful to catch depreciation sooner.Taken from https://github.com/ItinerisLtd/trellis_install_wp_cli_via_composer/blob/a1bc936d033641cc54556da5a7501d0685f8361d/.circleci/config.yml#L24-L32
See: https://docs.ansible.com/ansible-lint/rules/default_rules.html