Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ansible requirement to 2.8.0 #1147

Closed
wants to merge 1 commit into from

Conversation

tangrufus
Copy link
Collaborator

@swalkinshaw
Copy link
Member

I think we have some 2.7 compat code which would be nice to get rid of too. It's probably under lib but I don't remember exactly.

@tangrufus
Copy link
Collaborator Author

Never worked with python. No idea where to start.
Can you help? @swalkinshaw

@swalkinshaw
Copy link
Member

swalkinshaw commented Jan 22, 2020

Main thing I remember is this:

# handle Ansible 2.7 and 2.8 cases by normalizing each into a dict
try:
from ansible import context
self._options = context.CLIARGS
except ImportError:
self._options = vars(cli.options) if cli else {}

I believe with 2.8 we can just rely on context existing. That might be the only compat code actually

@swalkinshaw
Copy link
Member

Updated in #1166

@swalkinshaw swalkinshaw closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants