Update to PHP 7.4

[markjaquith]

fixes #1163

I left the PHP 7.2 service code in there, as well as adding new PHP 7.3 service code. I figure it doesn't hurt to keep it (it's just a few lines), and if anyone is upgrading from a 2018 version of Trellis to the PHP 7.4 version, it'll handle them leapfrogging PHP 7.3 completely.

[swalkinshaw]

I'll give this a try tonight but looks great 🎉

[tangrufus]

🎉 Looks good on my server.

Note: I didn't test on vagrant.

[markjaquith]

Didn't test on vagrant.

I did! Patch applied cleanly against my /trellis/ directory, and I ran vagrant provision. No problems at all.

[tangrufus]

I mean I didn't

[swalkinshaw]

🎉 thank you

[axi]

I also updated my /trellis and ran ansible-playbook server.yml -e env=staging

Website (test server ;-) went down for few seconds when ansible ensured php7.3-fpm is down...

Shouldn't that test (ensuring php7.3-fpm is down) be called at the end of provisioning as https://roots.io/docs/trellis/master/remote-server-setup/#re-provisioning states that

Re-provisioning is always assumed to be a safe operation

Note sure I should create an issue on that. Any idea to prevent that on production ? Just comment that portion should do I think

[swalkinshaw]

@axi you mean everything worked properly but php7.3-fpm service was still running? Nginx will be pointed to php7.4-fpm at that point though so it couldn't actually cause any issues? But yes, it should be stopped manually ideally.

Re-provisioning is always assumed to be a safe operation

This statement is slightly misleading I guess. It's assumed to be "safe" (non-breaking) if the changes themselves are safe.

[axi]

@swalkinshaw
On a running server, during re-provisionning, php7.3-fpm is shutdown before nginx config has been updated to point to php7.4-fpm, resulting in 502 error during few seconds. I thing shutting down php7.3-fpm at the end of provisionning should fix the short period where nginx still points to 7.3 but 7.3 is down. It's just a matter of order.
Update went well on every other points ;-)