Support Ansible 2.9

[swalkinshaw]

No description provided.

[tangrufus]

$ trellis provision production

TASK [wordpress-setup : Warn about deprecated Nginx includes directory] ********
System info:
  Ansible 2.9.6; Darwin
  Trellis version (per changelog): "Support Ansible 2.9"
---------------------------------------------------

The conditional check 'True in nginx_includes_templates.files |
map(attribute='path') | map('search', nginx_includes_deprecated |
regex_escape) | list' failed. The error was: no filter named 'search'

The error appears to be in '/xxx/roles/wordpress-
setup/tasks/nginx-includes.yml': line 13, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:


- name: Warn about deprecated Nginx includes directory
  ^ here

fatal: [111.222.333.444]: FAILED! => {}

$ trellis exec ansible --version
ansible 2.9.6
  config file = /xxx/trellis/ansible.cfg
  configured module search path = ['/yyy/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /xxx/.trellis/virtualenv/lib/python3.7/site-packages/ansible
  executable location = /xxx/.trellis/virtualenv/bin/ansible
  python version = 3.7.7 (default, Mar 10 2020, 15:43:33) [Clang 11.0.0 (clang-1100.0.33.17)]

---

Works fine on Ansible 2.8.10

$ trellis exec ansible --version
ansible 2.8.10
  config file = /xxx/trellis/ansible.cfg
  configured module search path = ['/yyy/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /xxx/.trellis/virtualenv/lib/python3.7/site-packages/ansible
  executable location = /xxx/.trellis/virtualenv/bin/ansible
  python version = 3.7.7 (default, Mar 10 2020, 15:43:33) [Clang 11.0.0 (clang-1100.0.33.17)]

---

Ansible announcements related to the search filter:

TASK [wordpress-setup : Warn about deprecated Nginx includes directory] ********
[DEPRECATION WARNING]: Using tests as filters is deprecated. Instead of using
`result|search` use `result is search`. This feature will be removed in version
 2.9. Deprecation warnings can be disabled by setting
deprecation_warnings=False in ansible.cfg.

See:

trellis/roles/wordpress-setup/tasks/nginx-includes.yml

Line 16 in 0875cc2

when: True in nginx_includes_templates.files | map(attribute='path') | map('search', nginx_includes_deprecated | regex_escape) | list

[tangrufus]

Also add ansible 2.9 tests on CircleCI, see: #1171

[swalkinshaw]

🤔 that's a tough one to fix since the suggestion won't work here.

One idea is to just remove that deprecation now? It's been 3-4 years 😅

[tangrufus]

One idea is to just remove that deprecation now? It's been 3-4 years 😅

Agree

[swalkinshaw]

Here it is: #1173