Remove custom output callback plugin #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
force-pushed
the
remove-custom-output-callback
branch
from
52f7375
to
f5f6f12
Compare
This custom output plugin had three main functions: 1. make the output for dictionaries cleaner (print key only) 2. display system info on failure for debugging purposes 3. couple other minor cosmetic changes The commit 5d5d1d2 already improved all the dict output by explicitly specifying a `label` which should always be used when needed from now on. This removes the need for modifying dict output at this callback level. While the system info can be helpful for troubleshooting, the most important parts of that information can be returned by running Ansibles' verbose mode (`-vv`). There's been many cases in the past of this information being confusing or misleading as well. While this custom output probably provides a small benefit, removing custom code like this makes it easier to maintain Trellis over the long term since Ansible provides less compatibility for these APIs.
swalkinshaw
force-pushed
the
remove-custom-output-callback
branch
from
f5f6f12
to
9d630c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This custom output plugin had three main functions:
The commit 5d5d1d2 already improved all the dict output by explicitly specifying a loop
labelwhich should always be used when needed from now on. This removes the need for modifying dict output at this callback level.While the system info can be helpful for troubleshooting, the most important parts of that information can be returned by running Ansibles' verbose mode (
-vv). There's been many cases in the past of this information being confusing or misleading as well.While this custom output probably provides a small benefit, removing custom code like this makes it easier to maintain Trellis over the long term since Ansible provides less compatibility for these APIs.
https://docs.roots.io/trellis/master/troubleshooting/#debugging might need some minor updating as well.