Remove dynamic SSH key host checks #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
force-pushed
the
remove-dynamic-host-key-checking
branch
from
e632abd
to
8b1bc5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a feature originally added in #798 (though the implementation has changed over time).
This was first added to avoid SSH host key algorithm mismatches between old versions of OpenSSH on the client (local machine) and servers (VM or remote server). In 2017, ed25519 (the preferred algorithm) was new enough in some macOS versions that this feature was needed. However, now it's 2022 and it should be extremely rare (if at all) that someone is using an OpenSSH version that old where ed25519 isn't supported.
Keeping this code makes maintaining Trellis and Ansible support more complex and has caused issues over the years. If it's not needed, then removing this feature entirely is a net benefit to simplify the codebase.