Support ARM64 arch in Mailhog role #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
force-pushed
the
mailhog-role-support-arm64
branch
from
25ce896
to
5ccaac1
Compare
|
Does geerlingguy/ansible-role-mailhog#29 solves the issue? |
|
Unfortunately not because that still points to the official repos which don't contain builds for arm64; only 32bit ARM. |
tangrufus
approved these changes
Oct 14, 2022
retlehs
requested changes
Oct 14, 2022
There was a problem hiding this comment.
Currently breaks provisioning at this step:
TASK [php : Copy PHP-FPM configuration file] ***********************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: {{ mailhog_install_dir }}/mhsendmail: 'mailhog_install_dir' is undefined
fatal: [default]: FAILED! => {"changed": false, "msg": "AnsibleUndefinedVariable: {{ mailhog_install_dir }}/mhsendmail: 'mailhog_install_dir' is undefined"}
5ccaac1
to
e9e16b0
Compare
`geerlingguy.mailhog` doesn't support arm64 (Apple Silicon) because the underlying binaries (`mailhog` and `mhsendmail`) don't have official `arm64` builds. To support this by default, we need to override the url variables to point to forks that have these builds. This adds a new "shim loader" `mailhog` role which simply loads the proper vars and then passes them to the included `geerlingguy.mailhog` role.
swalkinshaw
force-pushed
the
mailhog-role-support-arm64
branch
from
e9e16b0
to
66cc5a6
Compare
retlehs
approved these changes
Oct 15, 2022
paulbrzeski
pushed a commit
to paulbrzeski/trellis
that referenced
this pull request
Mar 3, 2023
`geerlingguy.mailhog` doesn't support arm64 (Apple Silicon) because the underlying binaries (`mailhog` and `mhsendmail`) don't have official `arm64` builds. To support this by default, we need to override the url variables to point to forks that have these builds. This adds a new "shim loader" `mailhog` role which simply loads the proper vars and then passes them to the included `geerlingguy.mailhog` role.
paulbrzeski
pushed a commit
to paulbrzeski/trellis
that referenced
this pull request
Mar 3, 2023
`geerlingguy.mailhog` doesn't support arm64 (Apple Silicon) because the underlying binaries (`mailhog` and `mhsendmail`) don't have official `arm64` builds. To support this by default, we need to override the url variables to point to forks that have these builds. This adds a new "shim loader" `mailhog` role which simply loads the proper vars and then passes them to the included `geerlingguy.mailhog` role.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geerlingguy.mailhogdoesn't support arm64 (Apple Silicon) because the underlying binaries (mailhogandmhsendmail) don't have officialarm64builds.To support this by default, we need to override the url variables to point to forks that have these builds.
This adds a new "shim loader"
mailhogrole which simply loads the proper vars and then passes them to the includedgeerlingguy.mailhogrole.