Allow user to set the timezone of the server and php #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| - name: Validate timezone variable | ||
| stat: path=/usr/share/zoneinfo/{{ default_timezone }} | ||
| register: valid_timezone |
There was a problem hiding this comment.
How about naming this timezone_path (since it might not be valid)?
|
This is great 👍. Just a few minor suggestions. I really like the helpful error message as well. |
Fix variable name and condition
Kimisyl
force-pushed
the
feature/set-timezone
branch
from
e8c43ab
to
6a78f1f
Compare
|
@swalkinshaw Fixed and rebased. |
|
Tested and works great. Thanks! |
swalkinshaw
added a commit
that referenced
this pull request
Aug 15, 2015
Allow user to set the timezone of the server and php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to set server's timezone from a user value. The user value will also be used to set
date.timezonefor php-fpm.defaultThe timezone is compared with zone files before being set to ensure its validity.