Fix #346: Keep headers in server block to fix HSTS #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nginx only inherits headers if there are NO `add_header` declarations in the child (`location` block in this case). From Nginx docs: There could be several add_header directives. These directives are inherited from the previous level if and only if there are no add_header directives defined on the current level.
swalkinshaw
force-pushed
the
hsts-fix
branch
from
7f04021
to
b1e6da5
Compare
swalkinshaw
added a commit
that referenced
this pull request
Nov 29, 2015
Fix #346: Keep headers in server block to fix HSTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nginx only inherits headers if there are NO
add_headerdeclarations inthe child (
locationblock in this case).From Nginx docs:
See 7f04021 for the fix only.