Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress vagrant-hostsupdater #458

Merged
merged 2 commits into from
Jan 12, 2016
Merged

Suppress vagrant-hostsupdater #458

merged 2 commits into from
Jan 12, 2016

Conversation

QWp6t
Copy link
Member

@QWp6t QWp6t commented Jan 6, 2016

Since we're using vagrant-hostmanager, we can safely suppress vagrant-hostsupdater to prevent duplicate hosts entries when users have both plugins installed.

This is untested, but it's consistent with their documentation.

@QWp6t
Copy link
Member Author

QWp6t commented Jan 6, 2016

Just tested it. It works.

==> default: Checking for host entries
==> default: Skipping adding host entries (config.vm.network hostsupdater: "skip" is set)

@mAAdhaTTah
Copy link
Contributor

So this is to prevent hostupdater from doing anything if it's already installed?

@QWp6t
Copy link
Member Author

QWp6t commented Jan 6, 2016

Yeah, exactly. vagrant-hostsupdater automatically updates hosts files regardless of whether your Vagrantfile explicitly tells it to. This PR opts out of it.

@swalkinshaw
Copy link
Member

@QWp6t 👍 CHANGELOG pls

swalkinshaw added a commit that referenced this pull request Jan 12, 2016
@swalkinshaw swalkinshaw merged commit 99fced3 into master Jan 12, 2016
@swalkinshaw swalkinshaw deleted the QWp6t-skiphostsupdater branch January 12, 2016 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants