Fix Nginx includes for Ansible 2.0 #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullyint
force-pushed
the
nginx-includes
branch
from
07ba25f
to
012878b
Compare
|
Since ansible now requires 2.0.0.2 could the extra logic for deciding on the backslashes be dropped? |
fullyint
force-pushed
the
nginx-includes
branch
from
012878b
to
ad53a66
Compare
|
right on @remailednet |
swalkinshaw
added a commit
that referenced
this pull request
Feb 7, 2016
Fix Nginx includes for Ansible 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ansible 1.9 the template task's
cwdwas the directory of the task file. In Ansible 2.0, it is the directory of the role. This PR enables the template task to accommodate either by using therole_pathvariable—an absolute path—instead of a relative path.Ansible 2.0 changes backreference escaping for the
regex_replacefilter, needing only 2 backslashes instead of 4, and in fact has a problem with 4. (Discussion at ansible/ansible#13426.)This PR uses aternaryfilter to give two vs. four backslashes depending on Ansible version.